feat(sourcecode): Serialize URI string

[lordrip]

Context

Currently, only the component name gets serialized into the URI string, the remaining parameters ar serialized in the parameters dictionary as follows:

  - from:
      uri: timer
      parameters:
        period: "1000"
        timerName: template

While this works for the Camel CLI, CamelK doesn't support this schema at the moment, causing the deployment to fail.

This commit writes the path parameters into the URI string, in order to support CamelK deployments, f.i.:

  - from:
      uri: timer:template
      parameters:
        period: "1000"

fixes: #884

[apupier]

searching how to reproduce but ended with a lot of double-dot:

[apupier]

[lordrip]

Awesome, thanks @apupier for catching it, I pushed a fix for a related issue

[apupier]

for rest-openapi, the path parameters are still written as attributes:

- route:
    id: route-4144
    from:
      id: from-1532
      uri: timer
      parameters:
        period: "1000"
        timerName: template
      steps:
        - log:
            id: log-3429
            message: template message
        - to:
            id: to-1027
            uri: rest-openapi
            parameters:
              operationId: myOperation
              specificationUri: afile-openapi.json

[apupier]

The component can be modified:

in source code, notice the resta instead of rest:

- route:
    id: route-4144
    from:
      id: from-1532
      uri: timer
      parameters:
        period: "1000"
        timerName: template
      steps:
        - log:
            id: log-3429
            message: template message
        - to:
            id: to-2923
            uri: resta
            parameters:
              uriTemplate: atemplate

[apupier]

surely related to previous one as it seems to be one-off shift but slightly different case:

[apupier]

• reported issues fixed
• not spotted new ones
• seems all cases covered by automates test cases

[lordrip]

• reported issues fixed

  • not spotted new ones

  • seems all cases covered by automates test cases

Thanks for the @apupier, but now I think I spotted something else that I think it would be better to fix.

As an example, the rest component has the following syntax: rest:method:path:uriTemplate, and while method and path are required parameters, urlTemplate it is not.

At this moment, when serializing the URI, if the urlTemplate is not provided, we end up with the following URI:

uri: "rest:get:myPath:"

I think it's not ideal, as it would be preferable to ignore the last : when there's an optional parameter.

This will require a bit more love since we would need to check the upcoming parameters as well, considering that for multiple optional parameters, we could provide just the last one, in which case, we would need to serialize the entire URI up to the last parameter 🙀

[lordrip]

Af this update, the optional parameters are only written if the next value is either required or provided.