fix(CanvasForm): Expression form hold stale data #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the issue in |
When the users includes config in a form field, which has same name as form field of another language/dataformat type, to which they can switch - the previously configured form field might get omited. The fix is to assign a key to the form, so React know that the form should be recreated without reusing the existing fields. fix: KaotoIO#904
lordrip
force-pushed
the
fix/expression-form-stale-data
branch
from
79dbbd9
to
d64fba6
Compare
Absolutely, thanks for catching this out 👌 |
tplevko
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the users include config in a form field, which has the same name as the form field of another language/data format type, to which they can switch - the previously configured form field might get omitted.
The fix is to assign a key to the form, so React knows that the form should be recreated without reusing the existing fields.
fix: #904