Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an about modal #931

Merged
merged 5 commits into from
Mar 13, 2024
Merged

added an about modal #931

merged 5 commits into from
Mar 13, 2024

Conversation

lhein
Copy link
Contributor

@lhein lhein commented Mar 12, 2024

fixes: #775

Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lordrip and others added 2 commits March 12, 2024 23:25
This commit provide information from the last commit when building the
application.

For the npm package, it overrides the `version.json` file during build time. For the web application, it provides the same information using the `define` property form the vite configuration.
feat(build): Add GIT info to the build stage
@lhein lhein marked this pull request as ready for review March 13, 2024 09:44
@lhein
Copy link
Contributor Author

lhein commented Mar 13, 2024

awesome, thanks for the help @lordrip

@lhein lhein requested a review from lordrip March 13, 2024 10:13
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code tests are not related to this PR

@lhein lhein merged commit fc7e31e into KaotoIO:main Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an About modal
2 participants