Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(902): Route and Kamelet container name issue #983

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

shivamG640
Copy link
Contributor

This PR is meant to fix #902 completely!

@shivamG640 shivamG640 marked this pull request as ready for review April 4, 2024 15:46
</EntitiesProvider>,
);

const NameField = screen.getByDisplayValue('user-source');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lordrip , I am using getByDisplayValue('user-source') here as getAllByLabelText('Id', {selector: 'input'}) couldnt find the target input field.

@lordrip
Copy link
Member

lordrip commented Apr 4, 2024

Oh, there's something to fix in the UI stories:
image

@lordrip lordrip merged commit 41aeea4 into KaotoIO:main Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kamelet and Route config needs improvements
2 participants