Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(695): Missing spacing between nested form fields #70

Merged
merged 1 commit into from Feb 2, 2024

Conversation

shivamG640
Copy link

Fixes KaotoIO/kaoto#695,

This is how it looks now:
image

@shivamG640
Copy link
Author

@lordrip,
It took me some time to learn about the issue where the canvas loading on the limited screen. I fixed it locally (actually a workaround to test this spacing change of mine). Not sure if we need that fix to be pushed as the hosted UI looks perfectly fine.
I am also unsure if I need to push the changes we added (restricting the sass version- "sass: 1.66.1") to link this repo with Kaoto-next for the local setup.

@lordrip
Copy link
Member

lordrip commented Feb 2, 2024

@lordrip, It took me some time to learn about the issue where the canvas loading on the limited screen. I fixed it locally (actually a workaround to test this spacing change of mine). Not sure if we need that fix to be pushed as the hosted UI looks perfectly fine. I am also unsure if I need to push the changes we added (restricting the sass version- "sass: 1.66.1") to link this repo with Kaoto-next for the local setup.

Great, thanks for taking care of this @shivamG640. My suggestion would be to split the problem into pieces, in our case, this PR fixes the main issue and I think it should be merged as it is ✌️

Now, for the saas problem, there are two things to do actually. The first one is to move both:

into the devDependencies section of the package.json file.

Once that's done, we would be able to link both projects without an issue, because the devDepencies are only used at build time, si yarn won't complain. In addition to that, we might need to check which sass version are we using in kaoto-next, ideally, both should be the same one, aka, the latest. At the moment of writing, is sass@1.7.0

Now, for the other issue you mentioned, what is the fix? if doesn't affect the runtime, we can incorporate it, could you tell me more about it?

@lordrip lordrip merged commit bbcc976 into KaotoIO:main Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing spacing between nested form fields
3 participants