bugFix: two gray line appear when device rotate from horizontal regular to horizontal compact

[zhongwuzw]

bug reproduce:

1. let device in horizontal regular state;
2. search some key(ps. has search results);
3. rotate device to horizontal compact state; then appear two gray line.

[zhongwuzw]

screenshot:

---

• I think it's a iOS system bug.

[Kapeli]

I still get a gray line with your fix:

I've seen these bugs in all iOS apps I've tried when rotating between portait/landscape or landscape/portrait, including Apple apps. The gray lines aren't the only issue, the whole search results table view seems to reposition.

Maybe we should fix it by ending the search and redoing it on rotation?

[zhongwuzw]

@Kapeli I updated the code, this time, I don`t remove top gray line, just adjust tableView insets.

[Kapeli]

This fixes the tableview part of the bug, but the searchbar doesn't reposition properly, so you still get something like this when switching from landscape to portrait:

Deactivating & reactivating the search controller seems to fix all bugs, but it's ugly as it loses scroll position and redoes the search: ee49a6e. I don't really like it.

I'll try to expand on your fix and get the searchbar to reposition properly.

[zhongwuzw]

@Kapeli , yeah, I agree with you, deactivating & reactivating seems not user friendly. If wants to position searchBar under statusBar, I think we can add code self.edgesForExtendedLayout = UIRectEdgeNone; to viewController.I'll try it later.

[Kapeli]

self.edgesForExtendedLayout = UIRectEdgeNone changes the way the status bar is drawn. Doesn't look good in my opinion.

Found these radars regarding this issue: https://openradar.appspot.com/21743785 and https://openradar.appspot.com/352525

[zhongwuzw]

@Kapeli , I changes the statusBar color by set DHSplitViewController backgroundColor. because of set self.edgesForExtendedLayout = UIRectEdgeNone, we should revise DHNavigationAnimator.

I also fix the docset download interface bug(reproduce step: in download interface,click searchBar,rotate,input some search key). screenshot below:

[Kapeli]

I think this is going to extreme lengths to partially fix a bug that's on Apple's end. I'd much rather leave things as is and have the bug present like every other app on iOS. I'm afraid we'll introduce a bunch of other bugs trying to fix this one.

[zhongwuzw]

Yep, I'll close the pull request.