Security Patches #1624
Merged
Security Patches #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majora2007
added a commit
that referenced
this pull request
Nov 8, 2022
* New Scan Loop (#1447)
* Staging the code for the new scan loop.
* Implemented a basic idea of changes on drives triggering scan loop. Issues: 1. Scan by folder does not work, 2. Queuing system is very hacky and needs a separate thread, 3. Performance degregation could be very real.
* Started writing unit test for new loop code
* Implemented a basic method to scan a folder path with ignore support (not implemented, code in place)
* Added some code to the parser to build out the idea of processing series in batches based on some top level folder.
* Scan Series now uses the new code (folder based parsing) and now handles the LocalizedSeries issue.
* Got library scan working with the new folder-based scan loop. Updated code to set FolderPath (for improved scan times and partial scan support).
* Wrote some notes on update library scan loop.
* Removed migration for merge
* Reapplied the SeriesFolder migration after merge
* Refactored a check that used multiple db calls into one.
* Made lots of progress on ignore support, but some confusion on underlying library. Ticket created. On hold till then.
* Updated Scan Library and Scan Series to exit early if no changes are on the underlying folders that need to be scanned.
* Implemented the ability to have .kavitaignore files within your directories and Kavita will parse them and ignore files and directories based on rules within them.
* Fixed an issue where ignore files nested wouldn't stack with higher level ignores
* Wrote out some basic code that showcases how we can scan series or library based on file events on the underlying system. Very buggy, needs lots of edge case testing and logging and dupplication checking.
* Things are working kinda. I'm getting lost in my own code and complexity. I'm not sure it's worth it.
* Refactored ScanFiles out to Directory Service.
* Refactored more code out to keep the code clean.
* More unit tests
* Refactored the signature of ParsedSeries to use IList. Started writing unit tests and reworked the UpdateLibrary to work how it used to with new scan loop code (note: using async update library/series does not work).
* Fixed the bug where processSeriesInfos was being invoked twice per series and made the code work very similar to old code (except loose leaf files dont work) but with folder based scanning.
* Prep for unit tests (updating broken ones with new implementations)
* Just some notes. Not sure I want to finish this work.
* Refactored the LibraryWatcher with some comments and state variables.
* Undid the migrations in case I don't move forward with this branch
* Started to clean the code and prepare for finishing this work.
* Fixed a bad merge
* Updated signatures to cleanup the code and commit to the new strategy for scanning.
* Swapped out the code with async processing of series on a small library
* The new scan loop is working in both Sync and Async methods. The code is slow and not optimized. This represents a good point to start polling and applying optimizations.
* Refactored UpdateSeries out of Scanner and into a dedicated file.
* Refactored how ProcessTasks are awaited to allow more async
* Fixed an issue where side nav item wouldn't show correct highlight and migrated to OnPush
* Moved where we start to stopwatch to encapsulate the full scan
* Cleaned up SignalR events to report correctly (still needs a redesign)
* Remove the "remove" code until I figure it out
* Put in extremely expensive series deletion code for library scan.
* Have Genre and Tag update the DB immediately to avoid dup issues
* Taking a break
* Moving to a lock with People was successful. Need to apply to others.
* Refactored code for series level and tag and genre with new locking strategy.
* New scan loop works. Next up optimization
* Swapped out the Kavita log with svg for faster load
* Refactored metadata updates to occur when the series are being updated.
* Code cleanup
* Added a new type of generic message (Info) to inform the user.
* Code cleanup
* Implemented an optimization which prevents any I/O (other than an attribute lookup) for Library/Series Scan. This can bring a recently updated library on network storage (650 series) to fully process in 2 seconds.
Fixed a bug where File Analysis was running everytime for each non-epub file.
* Fixed ARM x64 builds not being able to view PDF cover images due to a bad update in DocNet.
* Some code cleanup
* Added experimental signalr update code to have a more natural refresh of library-detail page
* Hooked in ability to send new series events to UI
* Moved all scan (file scan only) tasks into Scan Queue. Made it so scheduled ScanLibraries will now check if any existing task is being run and reschedule for 3 hours, and 10 mins for scan series.
* Implemented the info event in the events widget and added a clear all button to dismiss all infos and errors. Added --event-widget-info-bg-color
* Remove --drawer-background-color since it's not used
* When new series added, inject directly into the view.
* Some debug code cleanup
* Fixed up the unit tests
* Ensure all config directories exist on startup
* Disabled Library Watching (that will go in next build)
* Ensure update for series is admin only
* Lots of code changes, scan series kinda works, specials are splitting, optimizations are failing. Demotivated on this work again.
* Removed SeriesFolder migration
* Added the SeriesFolder migration
* Added a new pipe for dates so we can provide some nicer defaults. Added folder path to the series detail.
* The scan optimizations now work for NTFS systems.
* Removed a TODO
* Migrated all the times to use DateTime.Now and not Utc.
* Refactored some repo calls to use the includes flag pattern
* Implemented a check for the library scan optimization check to validate if the library was updated (type change, library rename, folder change, or series deleted) and let the optimization be bypassed.
* Added another optimization which will use just folder attribute of last write time if the drive is not NTFS.
* Fixed a unit test
* Some code cleanup
* Bump versions by dotnet-bump-version.
* Misc UI Fixes (#1450)
* Fixed collection cover images not rendering
* added a try/catch on sending email, so we fail silently if it doesn't send.
* Fixed Go Back not returning to last scroll position due to layoutmode change resetting, despite nothing changing.
* Fixed a bug where when turning between pages on default mode, the height calculations could get skewed.
* Fixed a missing case for card item where it wouldn't show tooltip title for series.
* Bump versions by dotnet-bump-version.
* New Scan Loop Fixes (#1452)
* Refactored ScanSeries to avoid a lot of extra work and fixed a bug where Scan Series would invoke the processing twice.
Refactored the series selection code during process such that we use Localized Name as well, for cases where the original name was changed.
Undid an optimization around Last Write time, since Linux file systems match how NTFS works.
* Fixed part of the query
* Added a NormalizedLocalizedName for quick searching in which a series needs grouping. Reworked scan loop code a bit to ensure we don't do extra work.
Tweaked the widget logic to help display better and not show "Nothing going on here".
* Fixed a bug where archives with ._ files would be counted as valid files, while they are actually just metadata files on Mac's.
* Fixed a broken unit test
* Bump versions by dotnet-bump-version.
* Simplify parent lookup with Directory.GetParent (#1455)
* Simplify parent lookup with Directory.GetParent
* Address comments
* Bump versions by dotnet-bump-version.
* Scan Loop Fixes (#1459)
* Added Last Folder Scanned time to series info modal.
Tweaked the info event detail modal to have a primary and thus be auto-dismissable
* Added an error event when multiple series are found in processing a series.
* Fixed a bug where a series could get stuck with other series due to a bad select query.
Started adding the force flag hook for the UI and designing the confirm.
Confirm service now also has ability to hide the close button.
Updated error events and logging in the loop, to be more informative
* Fixed a bug where confirm service wasn't showing the proper body content.
* Hooked up force scan series
* refresh metadata now has force update
* Fixed up the messaging with the prompt on scan, hooked it up properly in the scan library to avoid the check if the whole library needs to even be scanned. Fixed a bug where NormalizedLocalizedName wasn't being calculated on new entities.
Started adding unit tests for this problematic repo method.
* Fixed a bug where we updated NormalizedLocalizedName before we set it.
* Send an info to the UI when series are spread between multiple library level folders.
* Added some logger output when there are no files found in a folder. Return early if there are no files found, so we can avoid some small loops of code.
* Fixed an issue where multiple series in a folder with localized series would cause unintended grouping. This is not supported and hence we will warn them and allow the bad grouping.
* Added a case where scan series fails due to the folder being removed. We will now log an error
* Normalize paths when finding the highest directory till root.
* Fixed an issue with Scan Series where changing a series' folder to a different path but the original series folder existed with another series in it, would cause the series to not be deleted.
* Fixed some bugs around specials causing a series merge issue on scan series.
* Removed a bug marker
* Cleaned up some of the scan loop and removed a test I don't need.
* Remove any prompts for force flow, it doesn't work well. Leave the API as is though.
* Fixed up a check for duplicate ScanLibrary calls
* Bump versions by dotnet-bump-version.
* Scroll Resume (#1460)
* When we navigate from a page then back, resume back on the last scroll key (if clicked)
* Resume jump key position when navigating back to a page. Removed some extra blank space on collection detail when a collection doesn't have a summary or cover image.
* Ignore progress events on series cards
* Added a url to swagger for /, which could be reverse proxy url
* Bump versions by dotnet-bump-version.
* Misc UI fixes (#1461)
* Misc fixes
- Fixed modal being stretched when not needed.
- Fixed Logo vertical align
- Fixed drawer content scroll, and from it being squished due to overridden by bootstrap.
* series detail cover image stretch fix
- Fixes: Fixes series detail cover image being stretched on larger resolutions
* fixing empty lists scrollbar
* Fixing want to read error
* fixing unnecessary scrollbar
* Fixing recently updated tooltip
* Bump versions by dotnet-bump-version.
* Folder Watching (#1467)
* Hooked in a server setting to enable/disable folder watching
* Validated the file rename change event
* Validated delete file works
* Tweaked some logic to determine if a change occurs on a folder or a file.
* Added a note for an upcoming branch
* Some minor changes in the loop that just shift where code runs.
* Implemented ScanFolder api
* Ensure we restart watchers when we modify a library folder.
* Fixed a unit test
* Bump versions by dotnet-bump-version.
* More Scan Loop Bugfixes (#1471)
* Updated scan time for watcher to 30 seconds for non-dev. Moved ScanFolder off the Scan queue as it doesn't need to be there. Updated loggers
* Fixed jumpbar missing
* Tweaked the messaging for CoverGen
* When we return early due to nothing being done on library and series scan, make sure we kick off other tasks that need to occur.
* Fixed a foreign constraint issue on Volumes when we were adding to a new series.
* Fixed a case where when picking normalized series, capitalization differences wouldn't stack when they should.
* Reduced the logging output on dev and prod settings.
* Fixed a bug in the code that finds the highest directory from a file, where we were not checking against a normalized path.
* Cleaned up some code
* Fixed broken unit tests
* Bump versions by dotnet-bump-version.
* More Scan Loop Fixes (#1473)
* Added a ToList() to avoid a bug where a person could be removed from a list while iterating over the list.
* When deleting a series, want to read page will now automatically remove that series from the view.
* Fixed a series lookup which was ignoring format
* Ignore XML comment warnings
* Removed a note since it was already working that way
* Fixed unit test
* Bump versions by dotnet-bump-version.
* Misc UI Fixes (#1477)
* Tweaked a Migration to log correctly only if something is going to be done.
* Refactored Reading List Controller code into a dedicated service and cleaned up some methods that aren't needed anymore.
* Fixed a bug where adding a new item to a reading list wasn't adding it at the end.
* Fixed an issue where collection page would re-render the same covers on multiple items.
* Fixed a missing margin-top which made the page extras drawer not render correctly and hence unclosable on small screens.
* Added some timeout on manage users screen to give data time to flush.
Added a dedicated token log for account flows, in case url encoding plays a part (but from testing it doesn't).
* Reverted back to building for ES6 instead of es2020 for old Safari 12.5.5 browsers (10MB difference in build size).
* Cleaned up the logic in removing series not found during scan loop.
* Tweaked the timings for Library Watcher to 1 min and reprocess queue every 30 seconds.
* Bump versions by dotnet-bump-version.
* Added fixes for libvips (#1479)
* Bump versions by dotnet-bump-version.
* Tachiyomi + Fixes (#1481)
* Fixed a bootstrap bug
* Fixed repeating images on collection detail
* Fixed up some logic in library watcher which wasn't processing all of the queue.
* When parsing non-epubs in Book library, use Manga parsing for Volume support to better support Light Novels
* Fixed some bugs with the tachiyomi plugin api's for progress tracking
* Bump versions by dotnet-bump-version.
* Adding Health controller (#1480)
* Adding Health controller
- Added: Added API endpoint for a health check to streamline docker healthy status.
* review comment fixes
* Bump versions by dotnet-bump-version.
* Simplify Folder Watcher (#1484)
* Refactored Library Watcher to use Hangfire under the hood.
* Support .kavitaignore at root level.
* Refactored a lot of the library watching code to process faster and handle when FileSystemWatcher runs out of internal buffer space. It's still not perfect, but good enough for basic use.
* Make folder watching as experimental and default it to off by default.
* Revert #1479
* Tweaked the messaging for OPDS to remove a note about download role.
Moved some code closer to where it's used.
* Cleaned up how the events widget reports
* Fixed a null issue when deleting series in the UI
* Cleaned up some debug code
* Added more information for when we skip a scan
* Cleaned up some logging messages in CoverGen tasks
* More log message tweaks
* Added some debug to help identify a rare issue
* Fixed a bug where save bookmarks as webp could get reset to false when saving other server settings
* Updated some documentation on library watcher.
* Make LibraryWatcher fire every 5 mins
* Bump versions by dotnet-bump-version.
* Sort series by chapter number only when some chapters have no volume (#1487)
* Sort series by chapter number only when some chapters have no volume information
* Implement a Default static instance of ChapterSortComparer
* Further use Default static Comparers
* Add missing ToLit() as per comments
* SQLite Hangfire (#1488)
* Update to use SQLIte for Hangfire to retain information on tasks
* Updated all external links to have noopener noreferrer
* When watching folders, ensure the folders exist before creating watchers.
* Tweaked the messaging for Email Service and added link to the project.
* Bump versions by dotnet-bump-version.
* Bump versions by dotnet-bump-version.
* Fixed typeahead not working correctly (#1490)
* Bump versions by dotnet-bump-version.
* Release Testing Day 1 (#1491)
* Fixed a bug where typeahead wouldn't automatically show results on relationship screen without an additional click.
* Tweaked the code which checks if a modification occured to check on seconds rather than minutes
* Clear cache will now clear temp/ directory as well.
* Fixed an issue where Chrome was caching api responses when it shouldn't had.
* Added a cleanup temp code
* Ensure genres get removed during series scan when removed from metadata.
* Fixed a bug where all epubs with a volume would show as Volume 0 in reading list
* When a scan is in progress, don't let the user delete the library.
* Bump versions by dotnet-bump-version.
* Scan Loop Last Write Time Change (#1492)
* Refactored invite user flow to separate error handling on create user flow and email flow. This should help users that have unique situations.
* Switch to using files to check LastWriteTime. Debug code in for Robbie to test on rclone
* Updated Parser namespace. Changed the LastWriteTime to check all files and folders.
* Bump versions by dotnet-bump-version.
* Release Testing Day 2 (#1493)
* Added a no data section to collection detail.
* Remove an optimization for skipping the whole library scan as it wasn't reliable
* When resetting password, ensure the input is colored correctly
* Fixed setting new password after resetting, throwing an error despite it actually being successful.
Fixed incorrect messaging for Password Reset page.
* Fixed a bug where reset password would show the side nav button and skew the page.
Updated a lot of references to use Typed version for formcontrols.
* Removed a migration from 0.5.0, 6 releases ago.
* Added a null check so we don't throw an exception when connecting with signalR on unauthenticated users.
* Bump versions by dotnet-bump-version.
* Fixed a bug where a series with a relationship couldn't be deleted. (#1495)
* Bump versions by dotnet-bump-version.
* Release Testing Day 3 (#1496)
* Tweaked log messaging for library scan when no files were scanned.
* When a theme that is set gets removed due to a scan, inform the user to refresh.
* Fixed a typo and make Darkness -> Brightness
* Make download theme files allowed to be invoked by non-authenticated users, to allow new users to get the default theme.
* Hide all series side nav item if there are no libraries exposed to the user
* Fixed an API for Tachiyomi when syncing progress
* Fixed dashboard not responding to Series Removed and Added events.
Ensure we send SeriesRemoved events when they are deleted.
* Reverted Hangfire SQLite due to aborted jobs being resumed, when they shouldnt. Fixed some scan loop issues where cover gen wouldn't be invoked always on new libraries.
* Bump versions by dotnet-bump-version.
* Updating series detail cover style (#1498)
# FIxed
- Fixed: Fixed an issue with series detail cover when scaled down.
* Bump versions by dotnet-bump-version.
* v0.5.6 Release (#1499)
* Bump versions by dotnet-bump-version.
* Bookmark RBS + Dynamic PGO (#1503)
* Allow .NET to optimize code as it's running.
* Implemented the ability to restrict users Bookmark ability. By default, users will need to now opt-in to get bookmark roles.
* Fixed a tachiyomi progress syncing logic bug
* Bump versions by dotnet-bump-version.
* Updating series detail cover (#1509)
* Updating series detail cover
# Fixed
- Fixed: Fixed an issue where the series detail cover would resize too large on ultra wide displays.
* Fixing typos
* Bump versions by dotnet-bump-version.
* Logging Enhancements (#1521)
* Recreated Kavita Logging with Serilog instead of Default. This needs to be move out of the appsettings now, to allow auto updater to patch.
* Refactored the code to be completely configured via Code rather than appsettings.json. This is a required step for Auto Updating.
* Added in the ability to send logs directly to the UI only for users on the log route. Stopping implementation as Alerts page will handle the rest of the implementation.
* Fixed up the backup service to not rely on Config from appsettings.json
* Tweaked the Logging levels available
* Moved everything over to File-scoped namespaces
* Moved everything over to File-scoped namespaces
* Code cleanup, removed an old migration and changed so debug logging doesn't print sensitive db data
* Removed dead code
* Bump versions by dotnet-bump-version.
* Misc Enhancements (#1525)
* Moved the data connection for the Database out of appsettings.json and hardcoded it. This will allow for more customization and cleaner update process.
* Removed unneeded code
* Updated pdf viewer to 15.0.0 (pdf 2.6), which now supports east-asian fonts
* Fixed up some regex parsing for volumes that have a float number.
* Fixed a bug where the tooltip for Publication Status wouldn't show
* Fixed some weird parsing rules where v1.1 would parse as volume 1 chapter 1
* Fixed a bug where bookmarking button was hidden for admins without bookmark role (due to migration)
* Unified the star rating component in series detail to match metadata filter.
* Fixed a bug in the bulk selection code when using shift selection, where the inverse of what was selected would be toggled.
* Fixed some old code where if on all series page, only English as a language would return. We now return all languages of all libraries.
* Updated api/metadata/languages documentation
* Refactored some bookmark api names: get-bookmarks -> chapter-bookmarks, get-all-bookmarks -> all-bookmarks, get-series-bookmarks -> series-bookmarks, etc.
* Refactored all cases of createSeriesFilter to filterUtiltityService.
Added ability to search for a series on Bookmarks page.
Fixed a bug where people filters wouldn't respect the disable flag froms ettings.
* Cleaned up a bit of the circular downloader code.
* Implemented Russian Parsing
* Fixed an issue where some users that had a missing theme entry wouldn't be able to update their user preferences.
* Refactored normalization to exclude !, thus allowing series with ! to be different from each other.
* Fixed a migration exit case
* Fixed broken unit test
* Bump versions by dotnet-bump-version.
* Fixed a version issue with migration (#1526)
* Bump versions by dotnet-bump-version.
* Metadata Bugfixes (#1511)
* Fix XML deserialization of empty elements to integers
* Fix assumption that environment uses US time format
* Use series name as SeriesSort in epub
* Address some PR comments
* Add partial Equals(0 implementation to ComicInfo
* Update ComicInfo unittest. Revert previous version
* Bump versions by dotnet-bump-version.
* Configure Animation Module (#1504)
* Configure Animation Module
Configure the Animation Module of Angular to disable animation on older iOS devices (<14) where it causes animate not defined errors.
* Simplified disableAnimations
Removed the regex iOS version check as it seemed to return false on iOS 12.5.5 meaning that the `!('animate' in document.documentElement)` did the job already. This also allows users to enable the experimental feature Web Animations on iOS 12.5.5 to have them enabled again.
as note; navigator.userAgent returned the following on an iPad iOS 12.5.5
`Mozilla/5.0 (iPad; CPU OS 12_5_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.2 Mobile/15E148 Safari/604.1`
* added console output on disabled
Added console.error if Web Animations have been disabled due to the browser not supporting this.
* Bump versions by dotnet-bump-version.
* Reader Bugs + New Features (#1536)
* Updated a typo in manage tasks of Reoccuring -> Recurring
* Fixed a bug in MinimumNumberFromRange where a regex wasn't properly constructed which could skew results.
* Fixed a bug where Volume numbers that were a float wouldn't render correctly in the manga reader menu.
* Added the ability to double click on the image to bookmark it. Optimized the bookmark and unbookmark flows to remove 2 DB calls and reworked some flow of calls to speed it up.
Fixed some logic where when using double (manga) flow, both of the images wouldn't show the bookmark effect, despite both of them being saved. Likewise, fixed a bug where both images weren't updating UI state, so switching from double (manga) to single, the second image wouldn't show as bookmarked without a refresh.
* Double click works perfectly for bookmarking
* Collection cover image chooser will now prompt with all series covers by default.
Reset button is now moved up to the first slot if applicable.
* When a Completed series is fully read by a user, a nightly task will now remove that series from their Want to Read list.
* Added ability to trigger Want to Read cleanup from Tasks page.
* Moved the brightness readout to the label line and fixed a bootstrap migration bug where small buttons weren't actually small.
* Implemented ability to filter against release year (min or max or both).
* Fixed a log message that wasn't properly formatted when scan finished an no files changes.
* Cleaned up some code and merged some methods
* Implemented sort by Release year metadata filter.
* Fixed the code that finds ComicInfo.xml inside archives to only check the root and check explicitly for casing, so it must be ComicInfo.xml.
* Dependency updates
* Refactored some strings into consts and used TriggerJob rather than just enqueuing
* Fixed the prefetcher which wasn't properly loading in the correct order as it was designed.
* Cleaned up all traces of CircularArray from MangaReader
* Removed a debug code
* Fixed a bug with webtoon reader in fullscreen mode where continuous reader wouldn't trigger
* When cleaning up series from users' want to read lists, include both completed and cancelled.
* Fixed a bug where small images wouldn't have the pagination area extend to the bottom on manga reader
* Added a new method for hashing during prod builds and ensure we always use aot
* Fixed a bug where the save button wouldn't enable when color change occured.
* Cleaned up some issues in one of contributor's PR.
* Bump versions by dotnet-bump-version.
* Misc Polish and Fixes (#1542)
* Moved LibraryWatcher to utilize a queue for calculating the change event to ensure the Watcher doesn't get overwhelmed on large moves.
* Fixed a security vulnerability (https://huntr.dev/bounties/8a3e652f-d6bf-436e-877e-0eaf5c69ef95/). This will be disclosed in Stable release changelog.
* Tweaked the log message template
* Removed some dead code from Configuration json patcher
* Fixed a bug with the ComicInfo finding to properly handle root level.
Fixed a bug where sometimes scanner wouldn't choose the first file with ComicInfo for filling out information.
* Added new setting for managing how many logs files are allowed, just like how backups work.
* Added unit tests for new CleanupLogs code
* Fixed a bug where manga reader background color wasn't actually sending from the UI
* Added new stats for tracking to help understand usage in the app and what features are used or not.
* Fixed Stats url
* Fixed a bug where volumes that had larger than 1 difference wouldn't properly return next/prev chapter (for continuous reader)
* Remove a redundant test step in build pipeline, since it's already done at PR stage.
* Updated dockerfile to use the new Heath check endpoint
* Allow force to pass through to scan loop
* Removed some old config stuff from a safety check on config in entrypoint.sh
* Fixed broken unit tests due to new RBS check and how we setup mock data.
* Bump versions by dotnet-bump-version.
* Removed some debug code (#1543)
* Bump versions by dotnet-bump-version.
* Parser optimization part1 (#1531)
* Optimize CleanTitle
* Optimize MangaEditionRegex
* Optimize special regexes
* Refactor manga|comic special parsing into simple tests
* Word bind the special regexps. Support additional "special" use cases.
* Updates to address PR comments
* CleanTitle benchmarking
* Use a smaller Comics Data set for benchmarking
* Bump versions by dotnet-bump-version.
* Tachiyomi unit tests and fixes (#1549)
* Moved logic from TachiyomiController.cs to TachiyomiService.cs
* Added GetLatestChapter Unit Tests
* Tachiyomi more tests.
Implemented test for yearly volumes
* MarkVolumesUntilAsRead unit test
* Registered tachiyomi service.
Added new test
* Fixed test pages
* Added missing check if its single-file volume
* Removed dead code
* Added method documentation and breaked thousands with `_`
* Review details and renamed test method to be more descriptive
* Review changes
- Removed automapper
- Added spaces after commas
- Added class documentation (copied from controller)
- Made Culture static
- Added 'R' doc linking to docs.ms
- Added trycatch to service when saving progress and logged
- Removed redundant qualifiers
* finishing touches
Co-authored-by: Joseph Milazzo <joseph.v.milazzo@gmail.com>
* Bump versions by dotnet-bump-version.
* Folder Watching Polish + Epub Fix (#1550)
* Fixed entrypoint writing bad json (from develop)
* Fixed a bug where log file could write out a crap ton of information (serializing Series object) when a db error occurs.
* Fixed an issue with scan loop where concurrency issues could occur on new series being added.
* Tweaked the logger to suppress some noisy logs when using Debug log level.
* Fixed a regression with epub parsing from v3.2 of Vers-One's release
* Fixed up folder watching to work more reliable. Validated in production.
* Code cleanup
* Bump versions by dotnet-bump-version.
* Fallback to other locations when ComicInfo.xml not at root of archive (#1551)
* Fallback to other locations when ComicInfo.xml not at root of archive
* Better ComicInfo test coverage and benchmarks
* Add a rar archive to the ComicInfo test cases
* Bump versions by dotnet-bump-version.
* Series title word wrapping (#1519)
* Added text-break class to series title.
Simply added the class text-break from bootstrap to break on words.
https://getbootstrap.com/docs/5.0/utilities/text/#word-break
This has no issue with languages that do not or rarely use spaces, such as japanese and chinese. Used the following two series names to test;
- 今まで一度も女扱いされたことがない女騎士を女扱いする漫画
- Imamade Ichido mo Onnaatsukai sareta Koto ga Nai Onna Kishi wo Onnaatsukai suru
* Added text-break class to localized title
Also added the text-break bootstrap class to the localized title, removed the word-break rule from css as it is redundant.
* Enclosed LibraryName with span
Enclosed {{libraryName}} with a span to remove the added space before the title, aligning it again with the start of the subtitle. This mimics series-detail-component.html
* Bump versions by dotnet-bump-version.
* Nested Menus (#1554)
* added initial submenu
* added submenu - needs a bit of more work
* removed admin and nonadmin action split
* the whole menu is build under the resetactions function
* removed download from seriesAction
* changed submenu layout
changed submenu toggle icon
fix for the hovering of submenu toggle
* moved the cdMarkForCheck in the subscribe block
* Bump versions by dotnet-bump-version.
* Send To Device Support (#1557)
* Tweaked the logging output
* Started implementing some basic idea for devices
* Updated Email Service with new API routes
* Implemented basic DB structure and some APIs to prep for the UI and flows.
* Added an abstract class to make Unit testing easier.
* Removed dependency we don't need
* Updated the UI to be able to show devices and add new devices. Email field will update the platform if the user hasn't interacted with it already.
* Added ability to delete a device as well
* Basic ability to send files to devices works
* Refactored Action code to pass ActionItem back and allow for dynamic children based on an Observable (api).
Hooked in ability to send a chapter to a device. There is no logic in the FE to validate type.
* Fixed a broken unit test
* Implemented the ability to edit a device
* Code cleanup
* Fixed a bad success message
* Fixed broken unit test from updating mock layer
* Bump versions by dotnet-bump-version.
* Fixed a bug where when no devices, the submenu item would still render. (#1558)
* Bump versions by dotnet-bump-version.
* Extended Korean Filename Parsing Support (#1556)
* Added Some Korean Volume Matches
* Fixed Typo And Added Test Cases
* Restore Chapter Decimal Support
* Added Decimal Volume Support to -권, -화, -회 and -장
Merged -권 Pattern to -화, -회, -장 Pattern
Added Decimal Test to ParseVolumeTest
* Grouped Korean Tests
* Fixed Regexp Comment
* Bump versions by dotnet-bump-version.
* Disable Animations + Lots of bugfixes and Polish (#1561)
* Fixed inputs not showing inline validation due to a missing class
* Fixed some checks
* Increased the button size on manga reader (develop)
* Migrated a type cast to a pure pipe
* Sped up the check for if SendTo should render on the menu
* Don't allow user to bookmark in bookmark mode
* Fixed a bug where Scan Series would skip over Specials due to how new scan loop works.
* Fixed scroll to top button persisting when navigating between pages
* Edit Series modal now doesn't have a lock field for Series, which can't be locked as it is inheritently locked.
Added some validation to ensure Name and SortName are required.
* Fixed up some spacing
* Fixed actionable menu not opening submenu on mobile
* Cleaned up the layout of cover image on series detail
* Show all volume or chapters (if only one volume) for cover selection on series
* Don't open submenu to right if there is no space
* Fixed up cover image not allowing custom saves of existing series/chapter/volume images.
Fixed up logging so console output matches log file.
* Implemented the ability to turn off css transitions in the UI.
* Updated a note internally
* Code smells
* Added InstallId when pinging the email service to allow throughput tracking
* Bump versions by dotnet-bump-version.
* Auth Email Rework (#1567)
* Hooked up Send to for Series and volumes and fixed a bug where Email Service errors weren't propagating to the UI layer.
When performing actions on series detail, don't disable the button anymore.
* Added send to action to volumes
* Fixed a bug where .kavitaignore wasn't being applied at library root level
* Added a notification for when a device is being sent a file.
* Added a check in forgot password for users that do not have an email set or aren't confirmed.
* Added a new api for change email and moved change password directly into new Account tab (styling and logic needs testing)
* Save approx scroll position like with jump key, but on normal click of card.
* Implemented the ability to change your email address or set one. This requires a 2 step process using a confirmation token. This needs polishing and css.
* Removed an unused directive from codebase
* Fixed up some typos on publicly
* Updated query for Pending Invites to also check if the user account has not logged in at least once.
* Cleaned up the css for validate email change
* Hooked in an indicator to tell user that a user has an unconfirmed email
* Cleaned up code smells
* Bump versions by dotnet-bump-version.
* Misc Polish (#1569)
* Introduced a lock for DB work during the scan to hopefully reduce the concurrency issues
* Don't allow multiple theme scans to occur
* Fixed bulk actions not having all actions due to nested actionable menu changes
* Refactored the Scan loop to be synchronous to avoid any issues. After first loop, no real performance issues.
* Updated the LibraryWatcher when under many internal buffer full issues, to suspend watching for a full hour, to allow whatever downloading to complete.
* Removed Semaphore as it's not needed anymore
* Updated the output for logger to explicitly say from Kavita (if you're pushing to Seq)
* Fixed a broken test
* Fixed ReleaseYear not populating due to a change from a contributor around how to populate ReleaseYear.
* Ensure when scan folder runs, that we don't double enqueue the same tasks.
* Fixed user settings not loading the correct tab
* Changed the Release Year -> Release
* Added more refresh hooks in reader to hopefully ensure faster refreshes
* Reset images between chapter loads to help flush image faster. Don't show broken image icon when an image is still loading.
* Fixed the prefetcher not properly loading the correct images and hence, allowing a bit of lag between chapter loads.
* Code smells
* Bump versions by dotnet-bump-version.
* Scan Loop Fixes (#1572)
* Cleanup some messaging in the scan loop to be more context bearing
* Added Response Caching to Series Detail for 1 min, due to the heavy nature of the call.
* Refactored code to make it so that processing of series runs sync correctly.
Added a log to inform the user of corrupted volume from buggy code in v0.5.6.
* Moved folder watching out of experimental
* Fixed an issue where empty folders could break the scan loop
* Another fix for when dates aren't valid, the scanner wouldn't get the proper min and would throw an exception (develop)
* Implemented the ability to edit release year from the UI for a series.
* Added a unit test for some new logic
* Code smells
* Bump versions by dotnet-bump-version.
* Scan Loop Fortification (#1573)
* Cleanup some messaging in the scan loop to be more context bearing
* Added Response Caching to Series Detail for 1 min, due to the heavy nature of the call.
* Refactored code to make it so that processing of series runs sync correctly.
Added a log to inform the user of corrupted volume from buggy code in v0.5.6.
* Moved folder watching out of experimental
* Fixed an issue where empty folders could break the scan loop
* Another fix for when dates aren't valid, the scanner wouldn't get the proper min and would throw an exception (develop)
* Implemented the ability to edit release year from the UI for a series.
* Added a unit test for some new logic
* Code smells
* Rewrote the handler for suspending watching to be more resilient and ensure no two threads have a race condition.
* More error handling for when a ScanFolder is invoked but multiple series belong to that folder, log it to the user and default to a library scan.
* ScanSeries now will check for kavitaignores higher than it's own folder and respect library level.
* Fixed an issue where image series with a folder name containing the word "folder" could get ignored as it thought the image was a cover image.
When a series folder is moved or deleted, skip parent ignore finding.
* Removed some old files, added in scanFolder a check if the series found for a folder is in a book library and if so to always do a library scan (as books are often nested into one folder with multiple series). Added some unit tests
* Refactored some scan loop logic into ComicInfo, wrote tests and updated some documentation to make the fields more clear.
* Added a test for GetLastWriteTime based on recent bug
* Cleaned up some redundant code
* Fixed a bad merge
* Code smells
* Removed a package that's no longer used.
* Ensure we check against ScanQueue on ScanFolder enqueuing
* Documentation and more bullet proofing to ensure Hangfire checks work more as expected
* Bump versions by dotnet-bump-version.
* Restricted Profiles (#1581)
* Added ReadingList age rating from all series and started on some unit tests for the new flows.
* Wrote more unit tests for Reading Lists
* Added ability to restrict user accounts to a given age rating via admin edit user modal and invite user. This commit contains all basic code, but no query modifications.
* When updating a reading list's title via UI, explicitly check if there is an existing RL with the same title.
* Refactored Reading List calculation to work properly in the flows it's invoked from.
* Cleaned up an unused method
* Promoted Collections no longer show tags where a Series exists within them that is above the user's age rating.
* Collection search now respects age restrictions
* Series Detail page now checks if the user has explicit access (as a user might bypass with direct url access)
* Hooked up age restriction for dashboard activity streams.
* Refactored some methods from Series Controller and Library Controller to a new Search Controller to keep things organized
* Updated Search to respect age restrictions
* Refactored all the Age Restriction queries to extensions
* Related Series no longer show up if they are out of the age restriction
* Fixed a bad mapping for the update age restriction api
* Fixed a UI state change after updating age restriction
* Fixed unit test
* Added a migration for reading lists
* Code cleanup
* Bump versions by dotnet-bump-version.
* Misc Bugfixes (#1582)
* Fixed a bug with RBS on non-admin accounts
* Fixed a bug where get next/prev chapter wouldn't respect floating point volume numbers
* Fixed a bad migration version check
* When building kavita ignore exclusions, ignore blank lines.
* Hooked up the GetFullSeriesByAnyName to check against OriginalName exactly
* Refactored some code for building ignore from library root, to keep the code cleaner
* Tweaked some messaging
* Fixed a bad directory join when a change event occurs in a nested series folder.
* Fixed a bug where cover generation would prioritize a special if there were only chapters in the series.
* Fixed a bug where you couldn't update a series modal if there wasn't a release year present
* Fixed an issue where renaming the Series in Kavita wouldn't allow ScanSeries to see the files, and thus would delete the Series.
* Added an additional check with Hangfire to make sure ScanFolder doesn't kick off a change when a bunch of changes come through for the same directory, but a job is already running.
* Added more documentation
* Migrated more response caching to profiles and merged 2 apis into one, since they do the same thing.
* Fixed a bug where NotApplicable age ratings were breaking Recently Updated Series
* Cleaned up some cache profiles
* More caching
* Provide response caching on Get Next/Prev Chapter
* Code smells
* Bump versions by dotnet-bump-version.
* New Series Relation - Edition (#1583)
* Moved UpdateRelatedSeries from controller to SeriesService.cs
* Added 2 tests.
- UpdateRelatedSeries_ShouldDeletePrequelRelation
- UpdateRelatedSeries_ShouldNotAllowDuplicates
* Some docs and codestyle nitpicks
* Simplified tests and made easier to read
* Added 'Editions' series relation
* Missing code to properly show the relations in the UI
* Create Service for GetRelatedServices
* Added unit test. Assert Edition, Prequel and Sequel do not return parent while others do
* fixed missing userRating
* Add requested changes:
- Rename one test
- Split one test into two tests
* Bump versions by dotnet-bump-version.
* Release Polish (#1586)
* Fixed a scaling issue in the epub reader, where images could scale when they shouldn't.
* Removed some caching on library/ api and added more output for a foreign key constraint
* Hooked in Restricted Profile stat collection
* Added a new boolean on age restrictions to explicitly allow unknowns or not. Since unknown is the default state of metadata, if users are allowed access to Unknown, age restricted content could leak.
* Fixed a bug where sometimes series cover generation could fail under conditions where only specials existed.
* Fixed foreign constraint issue when cleaning up series not seen at end of scan loop
* Removed an additional epub parse when scanning and handled merging differently
* Code smell
* Bump versions by dotnet-bump-version.
* Release Shakeout Day 1 (#1591)
* Fixed an issue where reading list were not able to update their summary due to a duplicate title check.
* Misc code smell cleanup
* Updated .net dependencies and removed unneeded ones
* Fixed an issue where removing a series from want to read list page wouldn't update the page correctly
* Fixed age restriction not applied to Recommended page
* Ensure that Genres and Tags are age restricted gated
* Persons are now age gated as well
* When you choose a cover, the new cover will properly be selected and will focus on it, in the cases there are many other covers available.
* Fixed caching profiles
* Added in a special hook when deleting a library to clear all series Relations before we delete
* Bump versions by dotnet-bump-version.
* Release Shakeout Day 2 (#1594)
* Fixed a bad color on the PWA titlebar
* Added more unit tests, cleaned up some dead code, and made it so when age restriction is Not Applicable, the Unknowns field disables
* Don't show an empty menu when user has no permissions
* Fixed deleting a library with relation causing library deleting to fail
* Consolidated some includes code into one method for Series Repo
* Small fixes
* Bump versions by dotnet-bump-version.
* Release Shakeout 3 (#1597)
* Fixed a bug where bulk selection on series detail wouldn't allow you to select the whole card, only the checkbox.
* Refactored the implementation of MarkChaptersAsRead to streamline it.
* Fixed a bug where volume cards weren't properly updating their read state based on events from backend.
* Added [ScannerService] to more loggers
* Fixed invite user flow
* Fixed broken edit user flow
* Fixed calling device service on unauthenticated screens causing redirection
* Fixed reset password via email not working when success message was sent back
* Fixed broken white theme on book reader
* Small tweaks to white theme
* More fixes
* Adjusted AutomaticRetries
* Bump versions by dotnet-bump-version.
* UI Polish (#1599)
* Make the positioning of "Library | Recommended" consistent
* Fix reading lists not navigating back to their library after deletion
* Bump versions by dotnet-bump-version.
* Release Shakeout 4 (#1600)
* Fixed a bug where bulk selection on series detail wouldn't allow you to select the whole card, only the checkbox.
* Refactored the implementation of MarkChaptersAsRead to streamline it.
* Fixed a bug where volume cards weren't properly updating their read state based on events from backend.
* Added [ScannerService] to more loggers
* Fixed invite user flow
* Fixed broken edit user flow
* Fixed calling device service on unauthenticated screens causing redirection
* Fixed reset password via email not working when success message was sent back
* Fixed broken white theme on book reader
* Small tweaks to white theme
* More fixes
* Adjusted AutomaticRetries
* When an auth change occures, reset the devices in service so devices don't leak between profiles
* Fixed a bug where sendTo for series wasn't properly taking into account specials (on series detail page)
* Drop down how long series detail caches for to prevent signalr updates from refreshing the UI
* Close submenus when hovering over other items, not just other submenus
* Fixed a bug where scanning for themes would always report theme didn't exist
* Added Hangfire.db back in
* Fixed a bad build
* Bump versions by dotnet-bump-version.
* Fixed column layout on multiple components for the user settings (#1602)
#Fixed
- Fixed: Fixed an issue where the controls would extend outside of the container on the user account preferences page.
* Bump versions by dotnet-bump-version.
* v0.6 Release (#1603)
* Bump versions by dotnet-bump-version.
* Fix the black background in the ereader's white mode (#1610)
* Fix the black background in the ereader's white mode
* Fix the black background in the ereader's white mode
* Bump versions by dotnet-bump-version.
* Security Patches (#1624)
* Fixed an issue where migrate-email could be called when an admin already existed
* When logging in, ensure there is no bias towards username or password when rejecting
* Cleaned up some messaging around anonymous apis to ensure there are no attack vectors.
* Bump versions by dotnet-bump-version.
* Fix typo in toast notification (#1630)
* Bump versions by dotnet-bump-version.
* Bookmark and Reader bugs (#1632)
* Updated swiper and some packages for reported security issues
* Fixed reading lists promotion not working
* Refactor RenameFileForCopy to use iterative recursion, rather than functional.
* Ensured that bookmarks are fetched and ordered by Created date.
* Fixed a bug where bookmarks were coming back in the correct order, but due to filenames, would not sort correctly.
* Default installs to Debug log level given errors users have and Debug not being too noisy
* Added jumpbar to bookmarks page
* Now added jumpbar to bookmarks
* Refactored some code into pipes and added some debug messaging for prefetcher
* Try loading next and prev chapter's first/last page to cache so it renders faster
* Updated GetImage to do a bound check on max page.
Fixed a critical bug in how manga reader updates image elements src to prefetch/load pages. I was not creating a new reference which broke Angular's ability to update DOM on changes.
* Refactored the image setting code to use a single method which tries to use a cached image always.
* Refactored code to use getPage which favors cache and simplifies image creation code
* Bump versions by dotnet-bump-version.
* v0.6.1 Hotfix RC (#1635)
* Swapped out SQLite for Memory, but the one from hangfire. Added DisableConcurrentExecution on ProcessChange to avoid duplication when multiple threads execute at once.
* Fixed the Hangfire SQL issues with CPU/ram utilization some users are facing
* Fixed a case in SharpCompress fallback where an invalid ComicInfo wasn't picked up.
* When parsing epubs, if there is a volume in the epub title, try to parse and group. This is beneficial for Light Novels which are generally tagged this way.
* Fixed delete series in series detail not triggering
* Fixed some parsing logic for how we treat specials, like Annual and Omnibus.
* When scanning files, if the file is the cover image (loose leaf image), we reject it more quickly than previously.
* Added a potential bug marker
* Fixed a bug where Info was only showing Error level loggers
* Code smells
* Bump versions by dotnet-bump-version.
* Version bump for release
* Bugfix/UI fixes (#1645)
* Moved role selector to OnPush and made it so we disable all other roles when admin is selected.
* When there are no collections, don't point the user to the wiki unless they are an admin
* Fixed a bad piece of code for getPage in reader
* Bump versions by dotnet-bump-version.
Co-authored-by: tjarls <tjarls@gmail.com>
Co-authored-by: Robbie Davis <robbie@therobbiedavis.com>
Co-authored-by: Chris Plaatjes <kizaing@gmail.com>
Co-authored-by: Ocgineer <rvanbeek1@gmail.com>
Co-authored-by: ThePromidius <thepromidiusyt@gmail.com>
Co-authored-by: Korakot Santiudommongkol <47130579+KorakotSanti@users.noreply.github.com>
Co-authored-by: DeltaLaboratory <delta@deltalab.dev>
Co-authored-by: TheIceCreamTroll <33820904+TheIceCreamTroll@users.noreply.github.com>
Co-authored-by: pssandhu <pssandhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All issues will be made public on the next release
Changed
Fixed