-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis standalone client fails eagerly when disconnected #152
Conversation
I'll check this today |
3c647a7
to
5ce6ecc
Compare
5dcd091
to
d933d01
Compare
2d4d8ee
to
a03b155
Compare
The original too eager solution caused issues on Travis CI and possibly elsewhere
a03b155
to
234fc68
Compare
This works as expected. Now I am having the following issue. I don't know if this would be related with this PR. When you have a connection with Redis but it is not responding (a lot of requests, maybe), Redis might take 15 minutes to finally answer. In this case, it would be cool to have a timeout when we are doing a |
15 minutes? That looks more like a serious bug ... what takes that long? The It doesn't seem right to implement some other timeout without knowing the cause of this long response time |
Well, imagine that my server is getting a big overload. In my case, a simple Of course, I will have to do a fine tune on my server too 😄 |
Alright, then what about a general request timeout? |
yes, I was wondering if it is a good idea to have a configurable value when making an redis command. Something like "I want to try to get a value from redis but if this value is not returned in less than 250ms I will get a TimeoutException". Right now the behavior is "I want to try to get a value from redis and I will wait unlimited amount of time if I have connection with Redis". |
Redis standalone client fails eagerly when disconnected
Fixes #147
@tzimisce012 I figured out the solution to track the connection status. Since this PR the standalone client fails eagerly when the connection is not established. Would you be kind to test it? Does it resolve the issue you've opened?