Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] #7

Closed
archit-rastogi opened this issue Nov 24, 2023 · 5 comments
Closed

[BUG] #7

archit-rastogi opened this issue Nov 24, 2023 · 5 comments
Assignees
@KarimAziev
Labels
bug Something isn't working

Comments

@archit-rastogi
Copy link

Describe the bug
igist list sometimes does not load and returns empty list after spending a lot of time behind the scenes

To Reproduce
Steps to reproduce (if applicable)

Expected behavior
First time it works. Many times refreshing the gist list does not work

Relevant Version Numbers

  • igist: 20231114.928
  • ghub: 20231026.1306
  • transient: 20230901.1237

Stacktrace (if applicable):

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Emacs version: 29.1
  • Package version: ?
  • Operating system: macOS 10.15
@archit-rastogi archit-rastogi added the bug Something isn't working label Nov 24, 2023
@KarimAziev
Copy link
Owner

Thank you for reporting the issue!

  1. Could you please provide the exact steps you follow to reproduce this behavior? Are there any specific actions or steps that seem to trigger this issue, or does it appear randomly?
  2. Please enable url-debug by adding (setq url-debug t) to your Emacs configuration, then provide any debug messages from the *Messages* and *URL-DEBUG* buffers when the issue occurs. Additionally, the output from M-x view-lossage could be useful.
  3. Does the issue occur after Emacs has been idle, or during active use? igist uses debouncing with an idle-timer to rerender gists; other heavy tasks running concurrently might affect this.

@mattford63
Copy link

I too see this issue. If I first "explore" then "list" it fixes the initial "list" hang. If that helps any.

@KarimAziev
Copy link
Owner

@mattford63 Thanks! I will try to reproduce this behavior.

@KarimAziev
Copy link
Owner

KarimAziev commented Mar 20, 2024 •
edited

@mattford63 @archit-rastogi The issue you're experiencing with igist list loading might be related to a bug I've recently reported in the ghub repository, which can sporadically cause asynchronous requests to fail and not trigger error handling as expected. This could potentially lead to igist loading failures and returning an empty list after significant processing time.

For a more detailed discussion and ongoing efforts to diagnose the problem, please see the issue "Missing Headers" Error Not Triggering Callbacks in Asynchronous Requests #166.

In the meantime, any additional information you can provide following the steps outlined in my previous comments will be extremely helpful. These details are crucial for tracing and resolving the underlying issue effectively.

KarimAziev added a commit that referenced this issue Jun 8, 2024
@KarimAziev
fix: resolve the bug where gists sometimes do not load properly (#7)
888d4ad 
This fix resolves the issue where the `igist` list sometimes returns empty after a lengthy processing time by using `igist--request` instead of `ghub-request`.

Additionally, this fix addresses another bug introduced by the latest version of ghub (magit/ghub@2061136), where only the first page of gists was loaded, and subsequent pages were not fetched.

Issue: #7
KarimAziev added a commit that referenced this issue Jun 8, 2024
@KarimAziev
Release version 1.6.2
edb67a6 
*Fixes:*

- Resolved issue #7 where the `igist` list sometimes returned an empty list after a long processing time by using `igist--request` instead of `ghub-request`. Additionally, this fix addresses a bug caused by the latest version of ghub (magit/ghub@2061136), where only the first page of gists was loaded and subsequent pages were not fetched.

*Minor Changes:*
- Excluded igist mode-specific commands from the completion list in non-relevant modes to improve user experience and reduce clutter in the command completion list.
@KarimAziev
Copy link
Owner

I have fixed this issue in the igist release v1.6.2. I am now closing this issue. If you encounter this problem again, please feel free to reopen it. Thank you for your patience and feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KarimAziev KarimAziev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattford63 @archit-rastogi @KarimAziev