Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added husky and lint-staged #76

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Brandontam29
Copy link

Summary

Added husky and lint-staged. I am new to open source and doing this kind of config. I want to know if this is what you were looking for. I will probably have to do some changes before merging because I am not sure if this is good.

Key Changes

Only modified the package.json. Ran npm run test but Cannot find module 'react' from 'tests/DrawTypes.test.tsx'.

@KarimMokhtar
Copy link
Owner

Hi @Brandontam29 ,
Thanks for your contribution, Actually we are not using tests right now as it needs a special configuration so there is no need for that command.
Also could you please try to take a branch of yours and check if the linting is working?
Second thing please make sure you are following the semantic PR rules so your code passes the pipeline.
Thanks again for your effort.

@Brandontam29 Brandontam29 force-pushed the feature/husky-precommit-checking branch from 118c159 to db7450e Compare July 28, 2022 20:56
@Brandontam29
Copy link
Author

I don't know if you received the notification, but I just pushed the branch with commit message changed. Thank you.

@Brandontam29 Brandontam29 changed the title added husky and lint staged following the guide, havent tried though feat: added husky and lint-staged Jul 28, 2022
@Brandontam29
Copy link
Author

I changed the title of the pr, sorry for the inconvenience. I hope it works this time.

@KarimMokhtar
Copy link
Owner

Hi @Brandontam29 ,
Have you tried it locally? I have tried to test if it's gonna lint the staged files or not but it seems that it's not working.
Could you please check?

@KarimMokhtar KarimMokhtar force-pushed the feature/husky-precommit-checking branch from cf92457 to 8c2b44a Compare August 3, 2022 00:00
@Brandontam29
Copy link
Author

Let me test it this weekend. I have a few things going on right now.

@KarimMokhtar
Copy link
Owner

@Brandontam29 have you reached a new update on this or should i close the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants