Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern for debug symbols smoke test when using JDK 21 #162

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix pattern for debug symbols smoke test when using JDK 21 #162

merged 1 commit into from
Jun 5, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jun 5, 2023

@zakkak zakkak requested review from jerboaa and Karm June 5, 2023 09:35
jerboaa
jerboaa reviewed Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we consider a more lose pattern that matches more of those accept methods?

testsuite/src/it/java/org/graalvm/tests/integration/utils/GDBSession.java Outdated Show resolved Hide resolved
testsuite/src/it/java/org/graalvm/tests/integration/utils/GDBSession.java Outdated Show resolved Hide resolved
@jerboaa jerboaa added this to the Mandrel for JDK 21 milestone Jun 5, 2023
@zakkak
Copy link
Collaborator Author

zakkak commented Jun 5, 2023

Could we consider a more lose pattern that matches more of those accept methods?

Yes, that would probably be a better strategy

@zakkak zakkak force-pushed the 2023-06-05-fix-JDK21-gdbtest branch from f0a7c33 to fe90679 Compare June 5, 2023 10:15
@zakkak zakkak requested a review from jerboaa June 5, 2023 10:16
jerboaa
jerboaa approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zakkak zakkak merged commit 2f86a18 into Karm:master Jun 5, 2023
18 checks passed
@zakkak zakkak deleted the 2023-06-05-fix-JDK21-gdbtest branch June 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

@Karm Karm Awaiting requested review from Karm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mandrel for JDK 21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakkak @jerboaa