Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issue into README #12

Merged

Conversation

hughbris
Copy link
Contributor

I got caught out by this in a production environment and it took me a long time to find the closed issue which mention it (that is my fault!). A note in the README might help someone else find this important gotcha sooner.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hughbris and others added 2 commits June 29, 2023 15:56
.. about the cause and consequence of the know issue

Co-authored-by: Karmalakas <cronus.raven@gmail.com>
@hughbris
Copy link
Contributor Author

I added a new commit. I'm not sure how that gets integrated now.

@Karmalakas Karmalakas merged commit 93f6e54 into Karmalakas:main Jun 30, 2023
@Karmalakas
Copy link
Owner

I decided to merge it without creating a new release. When I do some update, it'll get in the release.
But I noticed only after merge the bold disappeared because of missing ** in the beginning of a note 😅 If you don't mind creating another PR to fix this, I would be grateful 🙂 But it's not that important to do this ASAP IMO

@hughbris
Copy link
Contributor Author

hughbris commented Jul 1, 2023

I decided to merge it without creating a new release. When I do some update, it'll get in the release.

Don't worry, I wouldn't create a new release for this either. I am pretty sure at least 90% of people who need to see this will be reading the latest version here on Github.

If you don't mind creating another PR to fix this, I would be grateful slightly_smiling_face

Will do, sorry for the blooper. I don't have a handy markdown previewer and I probably should!

hughbris added a commit to hughbris/grav-plugin-photoswipe that referenced this pull request Jul 1, 2023
@hughbris hughbris mentioned this pull request Jul 1, 2023
Karmalakas pushed a commit that referenced this pull request Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants