added support for postgres enums #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarnerTh
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Thanks for the PR! And sorry for the late response, I was quite busy lately.
The changes LGTM, but the test would need to be fixed. If you are motivated you could also add new tests that cover the new functionality.
If you do not have the time to make the changes please let me know, I will happily merge back the current state and finish it up by myself.
Todos:
- fix the test
- add new tests for enum columns
- add a flag to enable/disable the new functionality (I would suggest to default to disabled, so that the diagram does not get polluted due to large enums)
- update readme with the new flag
| @@ -114,7 +114,7 @@ func TestDatabaseIntegrations(t *testing.T) { | |||
| } | |||
|
|
|||
| assert.Nil(t, err) | |||
| assert.ElementsMatch(t, testCase.expectedColumns, columnNames) | |||
| //assert.ElementsMatch(t, testCase.expectedColumns, columnNames) | |||
| @@ -78,8 +78,9 @@ func (c mySqlConnector) GetTables(schemaName string) ([]string, error) { | |||
| } | |||
|
|
|||
| func (c mySqlConnector) GetColumns(tableName string) ([]ColumnResult, error) { | |||
| // FIXME add support for MySQL enums | |||
There was a problem hiding this comment.
If you are unfamiliar with MySQL I would fix this once it was merged back :)
Merged
|
Get's closed in favour for #26 because there is no response from the contributor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.