Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Here is an overview of the changes proposed in this pull request:
Changes proposed
1) Replace use of the deprecated function
fct_explicit_na
.Why: Updating R results in an deprecated function error where
fct_explicit_na
is used, as documented in #19.Fix: Replace
fct_explicit_na
withfct_na_value_to_level
.2) Replace use of the deprecated function
aes_string
.Why:
aes_string
was deprecated in a recent version ofggplot
.Fix: Use the
.data
pronoun in theaes
function where the aesthetics are specified inggplot
commands in the plot and legend functions.3) Fix problems with use of external vectors in selecting functions.
Why: Using an external vector in selections was deprecated in a recent version of
tidyselect
.Fix: Use
all_of
where vectors are used in theselect
function; replace input in thegroup_by_at
function with a character vector of column names.4) Update package dependencies in vignettes.
Why: Packages
forcats
andtidyverse
are required to be loaded in order for the Global Patterns Data and Human Microbiome Project 1 & 2 vignettes to run.Fix: Add the necessary package load commands in the vignettes that require them.
Additionally: add a param comment to document recently added as_relative_abundance parameter in the
prep_mdf
function.Checks
Thank you!
Best,
Anagha