Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS0601 does not work - calibration type 2 and real mode is false #155

Closed
aso824 opened this issue Jan 4, 2022 · 1 comment · Fixed by #405
Closed

TS0601 does not work - calibration type 2 and real mode is false #155

aso824 opened this issue Jan 4, 2022 · 1 comment · Fixed by #405
Labels
bug Something isn't working stale Long time no activity
Milestone

Comments

@aso824
Copy link

aso824 commented Jan 4, 2022

Hi,

I noticed that this addon totally does not work for me, so turned logs on and found lines like that:

2022-01-05 00:10:18 DEBUG (MainThread) [custom_components.ai_thermostat.climate] ai_thermostat True
2022-01-05 00:10:18 DEBUG (MainThread) [custom_components.ai_thermostat.climate] ai_thermostat: running calibration
2022-01-05 00:10:18 DEBUG (MainThread) [custom_components.ai_thermostat.climate] ai_thermostat triggered states > window open: False night mode: False Mode: heat set: heat has_mode: False Calibration: 0 set_temp: 19.0 cur_temp: 20.8 Model: TV02-Zigbee Calibration type: 2 call for heat: True TRV: Kaloryfer w sypialni

So, dig into code and found out that when I have calibration type equals to 2, and real mode is false (whatever this means), nothing happens - there is no condition for that situation:
https://github.com/KartoffelToby/ai_thermostat/blob/46b89c8cd483ee25a76104ff0dd650a22fd564b3/custom_components/ai_thermostat/climate.py#L731-L745

Found out that type 2 is default and it's overrided by device configuration, which seems to be missing for my TRV which is identfied as "TV02-Zigbee" but it's newest generation of TS0601. Could you add a warning in case of that situation + include my TRV into configuration?

Btw. which Python version HA requires? Is it possible to use Enum which was introduced in Python 3.4?

@RubenKelevra RubenKelevra added the bug Something isn't working label Jan 5, 2022
@RubenKelevra RubenKelevra added this to the 1.0 milestone Jan 5, 2022
@stale
Copy link

stale bot commented May 6, 2022

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale Long time no activity label May 6, 2022
@fettlaus fettlaus mentioned this issue Jun 9, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Long time no activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants