Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for cooling devices too (AC) #1059

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Conversation

KartoffelToby
Copy link
Owner

Motivation:

Add the option to add cooling entities to BT

Related issues:

tomlevels and others added 4 commits January 6, 2023 15:23
@KartoffelToby KartoffelToby mentioned this pull request Sep 20, 2023
3 tasks
Add Basic Support for cooling
@KartoffelToby KartoffelToby linked an issue Sep 20, 2023 that may be closed by this pull request
@KartoffelToby KartoffelToby changed the title Add the support for cooling devices too (AC) [WIP] Add the support for cooling devices too (AC) Sep 20, 2023
@KartoffelToby KartoffelToby marked this pull request as draft September 20, 2023 16:54
@KartoffelToby KartoffelToby changed the title [WIP] Add the support for cooling devices too (AC) Add the support for cooling devices too (AC) Sep 22, 2023
@KartoffelToby KartoffelToby marked this pull request as ready for review September 22, 2023 18:23
@KartoffelToby
Copy link
Owner Author

@wtom would be nice if you can try it out :)

@wtom
Copy link
Collaborator

wtom commented Sep 24, 2023

The hvac_action seems to be a little buggy. For heating it's working well, but for cooling, it jumps always so idle after some seconds (i think the TRV update_hvac_action) is overwriting it. We should move the TRV code to the climate.py and add the lines for the cooler. Maybe also add the tolerance there for cooling?

Other than that, seems to work fine. No other errors found.

@KartoffelToby KartoffelToby merged commit f5eabfd into master Oct 31, 2023
6 checks passed
@KartoffelToby KartoffelToby mentioned this pull request Oct 31, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants