Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update climate.py #1179

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Update climate.py #1179

merged 3 commits into from
Dec 27, 2023

Conversation

NinDTendo
Copy link
Contributor

Fixed HVAC_ACTION Attribute to accomodate 'off' state

Motivation:

Basing my automations on HVAC_Action but noticed it not working properly for the better thermostats.
Therefore implementing a fix accomodating OFF state.

Changes:

added logic for off-state

Related issue (check one):

  • fixes #
  • there is no related issue ticket

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • The code change is tested and works locally.

Test-Hardware list (for code changes)

HA Version: 2023.11.1
Zigbee2MQTT Version: ZHA
TRV Hardware: Aqara E1 TRV

New device mappings

  • I avoided any changes to other device mappings
  • There are no changes in climate.py

Fixed HVAC_ACTION Attribute to accomodate 'off' state
@KartoffelToby
Copy link
Owner

@NinDTendo thanks for you work! Can you Check the Merge conflict with master?

fixed indentation error on line 1096
@NinDTendo
Copy link
Contributor Author

The issue should be resolved with the latest commit! @KartoffelToby

@KartoffelToby KartoffelToby merged commit c2f2a65 into KartoffelToby:master Dec 27, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants