Calibration adjustment/cleanup and refactor #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Using better thermostat myself, I was unhappy with the local calibration(also saw an issue about that) and sneaked around the code.
Changes:
Refactors:
CalibrationType
andCalibrationMode
instead of extra const variablesFIX_CALIBRATION
toAGGRESIVE_CALIBRATION
Fixes:
Enhancements:
calibration adjustment also on
hvac_mode
change. Excessive updating is avoided by comparingold != new
Related issue (check one):
Checklist (check one):
Test-Hardware list (for code changes)
HA Version: 2023.10.1 / OS: 10.5
Zigbee2MQTT Version: 1.33.1-1
New device mappings
No device mappings.