Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiplatform empty project #2

Merged
merged 4 commits into from Mar 5, 2019
Merged

Add multiplatform empty project #2

merged 4 commits into from Mar 5, 2019

Conversation

tonilopezmr
Copy link
Contributor

@tonilopezmr tonilopezmr commented Mar 5, 2019 •
edited

馃搶 References

馃帺 What is the goal?

  • Add empty multiplatform project to share code between Android an IOS
  • Add github templates

馃摑 How is it being implemented?

  • Create a new project selecting Kotlin (Mobile Android/IOS) option, which will create the gradle project.

screen shot 2019-03-05 at 10 57 30

  • The name of the artifact it's KotlinMultiplatformApp, and the application id com.karumi.dribbble.app
  • Add Karumi github templates

Serchinastico
Serchinastico reviewed Mar 5, 2019
View reviewed changes
app/build.gradle Outdated
android {
compileSdkVersion 28
defaultConfig {
applicationId 'org.jetbrains.kotlin.mpp_app_android'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App id should be com.karumi.multiplatform.dribbble or something similar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally I added com.karumi.dribbble.app as you suggested by slack

@tonilopezmr tonilopezmr marked this pull request as ready for review March 5, 2019 10:11
Serchinastico
Serchinastico approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@Serchinastico Serchinastico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憣 we will be removing most of these files in the process but it's great to have them in a commit in the repo for future reference.

Good job, Toni

@tonilopezmr tonilopezmr merged commit b425535 into master Mar 5, 2019
@tonilopezmr tonilopezmr deleted the empty-kotlin-project branch March 5, 2019 10:14
@tonilopezmr tonilopezmr mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serchinastico Serchinastico Serchinastico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Issue and Pull Request templates
2 participants
@tonilopezmr @Serchinastico