Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git tag for the memory patches #24

Open
SimonBoothroyd opened this issue Dec 29, 2020 · 3 comments
Open

Add a git tag for the memory patches #24

SimonBoothroyd opened this issue Dec 29, 2020 · 3 comments

Comments

@SimonBoothroyd
Copy link

SimonBoothroyd commented Dec 29, 2020

It seems that the 5.1.1 release has memory related issues as mentioned in #20, but which also appear to be the cause of the segmentation faults which are preventing the new release of this framework being packaged for conda-forge: conda-forge/metis-feedstock#30

For the segmentation faults at least, it seems like the 38a8fb0 and 36262ad commits resolve the issues.

@karypis would you be able to create a new tag for a 5.1.2 release (similar as was done for #13) to include the latest commits so we can proceed with the conda-forge packaging? It would be very much appreciated!

Similarly adding new tags for GKlib would also be great (especially as this is now an external dependency) as this would allow us to also package the latest release: conda-forge/staged-recipes#12547

Thanks for your help, and this fantastic framework!

@hadim
Copy link

hadim commented Jan 8, 2021

Gklib is now packaged on conda forge https://github.com/conda-forge/gklib-feedstock

@SimonBoothroyd
Copy link
Author

@karypis I just wanted to check-in to see if you had any thoughts about this?

@Chrismarsh
Copy link

I agree this would be helpful and streamline downstream consumer versioning. As well it seems 5.1.1 and master build very different against gklib it would help in differentiating them in build systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants