Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to 5.1.1 #30

Closed
wants to merge 3 commits into from
Closed

bump to 5.1.1 #30

wants to merge 3 commits into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Sep 3, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Sep 3, 2020

This is required to build dgl but blocked by KarypisLab/METIS#13. We need a git tag from upstream.

It is also blocked by conda-forge/staged-recipes#12547

@hadim hadim changed the title bump to next version bump to 5.1.1 Sep 13, 2020
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Sep 14, 2020

@hadim
Copy link
Member Author

hadim commented Sep 14, 2020

@SylvainCorlay @basnijholt one of you wants to review this?

@basnijholt
Copy link
Contributor

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@basnijholt
Copy link
Contributor

@hadim, many tests are still failing.

@hadim
Copy link
Member Author

hadim commented Sep 14, 2020

Yes with a glibc error similar to this:

7f10252b2000-7f10252b3000 rw-p 00094000 08:01 3120629                    /home/conda/feedstock_root/build_artifacts/metis_1600041346401/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/libmetis.so
7f10252b3000-7f10252b5000 rw-p 00000000 00:00 0 
7f10252b5000-7f10252b6000 r--p 00020000 08:01 2090911                    /lib64/ld-2.12.so
7f10252b6000-7f10252b7000 rw-p 00021000 08:01 2090911                    /lib64/ld-2.12.so
7f10252b7000-7f10252b8000 rw-p 00000000 00:00 0 
7ffe7b8ee000-7ffe7b910000 rw-p 00000000 00:00 0                          [stack]
7ffe7b94f000-7ffe7b952000 r--p 00000000 00:00 0                          [vvar]
7ffe7b952000-7ffe7b954000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
*** glibc detected *** gpmetis: munmap_chunk(): invalid pointer: 0x00005595871650d0 **

I don't really get what is happening.

@basnijholt
Copy link
Contributor

Unfortunately, I don't have time to look into this right now.

@hadim
Copy link
Member Author

hadim commented Sep 17, 2020

all good @basnijholt.

Let's let this open and hopefully someone will come with a fix. I'll try to investigate if I can find some time.

@SimonBoothroyd
Copy link

@hadim it looks like the main author added a couple of commits patching memory issues (KarypisLab/METIS@38a8fb0, KarypisLab/METIS@36262ad) - patching 5.1.1 with these changes seems to resolve the segfault when building and testing with build-locally.

So it might require a new release with the patches included to resolve this?

@hadim
Copy link
Member Author

hadim commented Dec 28, 2020

So it might require a new release with the patches included to resolve this?

Yes a new release is required indeed. That being said you can test the new commits in that PR or another one if you wish.

@hadim
Copy link
Member Author

hadim commented Dec 29, 2020

@SimonBoothroyd do you want to open an new issue upstream to ask for a new release?

@SimonBoothroyd
Copy link

@hadim I'd be happy to. I'm currently just looking into the windows build failures in conda-forge/staged-recipes#12547 but will follow up after I've finished with that.

@SimonBoothroyd
Copy link

We may also need to enable these flags to make sure things work correctly with dgl: https://github.com/dmlc/dgl/blob/9a7235faf2835d424c4587e703024248e6b9f465/CMakeLists.txt#L121-L128

@hadim
Copy link
Member Author

hadim commented Dec 31, 2020

@SimonBoothroyd after conda-forge/staged-recipes#12547 is merged can I let you take over this PR (or create a new one based on this one maybe).

My bandwidth will be very limited to keep working on a dgl conda package.

@SimonBoothroyd
Copy link

Sure that sounds good with me.

@hadim
Copy link
Member Author

hadim commented Dec 31, 2020

Thanks! And I would be happy to review/test things if you need.

@hadim
Copy link
Member Author

hadim commented Jan 29, 2022

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mikemhenry
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@SimonBoothroyd
Copy link

It seems a new tagged version is now available that hopefully won't segfault...https://github.com/KarypisLab/METIS/releases/tag/v5.2.1

Not sure if DGL is compatible with this however... there were some pretty big changes IIRC but I can't remember if those included API breaks..

@mikemhenry
Copy link
Contributor

@SimonBoothroyd That is what I am worried about, maybe we can get lucky with a patch for DGL if it is simple...

@mikemhenry mikemhenry mentioned this pull request Apr 24, 2023
5 tasks
@hadim
Copy link
Member Author

hadim commented Jul 13, 2023

closing in favour of #32

@hadim hadim closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants