-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to 5.1.1 #30
bump to 5.1.1 #30
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is required to build It is also blocked by conda-forge/staged-recipes#12547 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The build works but I get a weird glibc error during testing: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=208979&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=995 |
@SylvainCorlay @basnijholt one of you wants to review this? |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. |
@hadim, many tests are still failing. |
Yes with a glibc error similar to this:
I don't really get what is happening. |
Unfortunately, I don't have time to look into this right now. |
all good @basnijholt. Let's let this open and hopefully someone will come with a fix. I'll try to investigate if I can find some time. |
@hadim it looks like the main author added a couple of commits patching memory issues (KarypisLab/METIS@38a8fb0, KarypisLab/METIS@36262ad) - patching 5.1.1 with these changes seems to resolve the segfault when building and testing with So it might require a new release with the patches included to resolve this? |
Yes a new release is required indeed. That being said you can test the new commits in that PR or another one if you wish. |
@SimonBoothroyd do you want to open an new issue upstream to ask for a new release? |
@hadim I'd be happy to. I'm currently just looking into the windows build failures in conda-forge/staged-recipes#12547 but will follow up after I've finished with that. |
We may also need to enable these flags to make sure things work correctly with dgl: https://github.com/dmlc/dgl/blob/9a7235faf2835d424c4587e703024248e6b9f465/CMakeLists.txt#L121-L128 |
@SimonBoothroyd after conda-forge/staged-recipes#12547 is merged can I let you take over this PR (or create a new one based on this one maybe). My bandwidth will be very limited to keep working on a dgl conda package. |
Sure that sounds good with me. |
Thanks! And I would be happy to review/test things if you need. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
…nda-forge-pinning 2022.01.29.15.10.18
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.02.24.11.04.05
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
It seems a new tagged version is now available that hopefully won't segfault...https://github.com/KarypisLab/METIS/releases/tag/v5.2.1 Not sure if DGL is compatible with this however... there were some pretty big changes IIRC but I can't remember if those included API breaks.. |
@SimonBoothroyd That is what I am worried about, maybe we can get lucky with a patch for DGL if it is simple... |
closing in favour of #32 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)