Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
converter.sh: Don't parallelise write_hash (#17742)
write_hash appends to scratch_files/hashes.csv without any form of locking, but is performed in parallel. Additionally there is no synchronisation to wait for all write_hash invocations to have completed before reading the CSV. This results in non-deterministic breakage and missing hashes in the resulting files. Remove parallelism here to fix the breakage. Note, just calling wait_for_jobs after the loop reduces the occurrence of problems, but is insufficient since multiple appends do occasionally race and hashes may still be missing.
- Loading branch information