Fix Kotlin build problem #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KasemJaffer Please fix this bug dude |
KasemJaffer
reviewed
Mar 14, 2021
android/src/main/kotlin/com/kasem/receive_sharing_intent/ReceiveSharingIntentPlugin.kt
Outdated
Show resolved
Hide resolved
KasemJaffer
reviewed
Mar 14, 2021
android/src/main/kotlin/com/kasem/receive_sharing_intent/ReceiveSharingIntentPlugin.kt
Outdated
Show resolved
Hide resolved
KasemJaffer
reviewed
Mar 14, 2021
| @@ -149,7 +149,8 @@ public class SwiftReceiveSharingIntentPlugin: NSObject, FlutterPlugin, FlutterSt | |||
| guard let path = getAbsolutePath(for: $0.path) else { | |||
| return nil | |||
| } | |||
| return SharedMediaFile.init(path: $0.path, thumbnail: nil, duration: nil, type: $0.type) | |||
| let pathWithoutPrefix = String($0.path.dropFirst(7))//knock 'file://' off here... | |||
There was a problem hiding this comment.
This patch is taken from here #141. @LazyDave76 is the author of both patches.
There was a problem hiding this comment.
The shared media object has a path property which already contains "file://" on iOS.
This results in file not found when looking up the path in iOS because the value looks like "file://file://PathToCopiedFile"
There was a problem hiding this comment.
having 'fixed' this bug in a pretty hacky way - this is probably what it should look like:
Suggested change
| let pathWithoutPrefix = String($0.path.dropFirst(7))//knock 'file://' off here... | |
| return SharedMediaFile.init(path: path, thumbnail: nil, duration: nil, type: $0.type) |
seems that the path is url encoded though and there are fun times with files with spaces...
|
@KasemJaffer |
|
@KasemJaffer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of @LazyDave76's pull request #137
Close #144