#154: Replace "atom evaluation returned null" message #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitae57
requested review from
matzuk,
AzamatCherchesov,
eakurnikov and
RuslanMingaliev
as code owners
AzamatCherchesov
approved these changes
Nov 6, 2022
AzamatCherchesov
deleted the
issue-154/Provide_human_readable_webview_exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154
I know that checking that exception is RuntimeException and it's message contains some string does not look like a proper indicator that it is a web view related exception and I agree, however google spits out only web view related results when you search for "atom evaluation returned null".
To see what user sees in console when such exception occurs check out file below. Exact ui element that threw exception during interaction could be easily found using stack trace
attachment.txt