Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH: made KaspressoRunner open class #467

Merged
merged 1 commit into from
Dec 28, 2022
Merged

TECH: made KaspressoRunner open class #467

merged 1 commit into from
Dec 28, 2022

Conversation

dalapenko
Copy link
Contributor

In changes 1.5 you added new KaspressoRunner, but I think you forget make this open. Consumers of kaspresso framework can't use inheritance and add self logic to runner. This can be problem and as example in our company we can't update framework to 1.5 without fixing this because we need to extend logic in runner.

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AzamatCherchesov AzamatCherchesov merged commit 6388b74 into KasperskyLab:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants