Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable screenshot timestamps #52

Closed

Conversation

aartikov
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@matzuk matzuk self-requested a review November 22, 2019 03:48
Copy link
Member

@matzuk matzuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your contribution!
The first question here is why do you need to remove timestamps? Timestamp resolves the following problem. If your test passes more than one time per concrete suite then you will have only screenshots from the last attempt (each new attempt overwrites old one). That's why the timestamp in the test's name comes to help.
But. We can suggest another solution. Put the test's screenshots in a new folder each time. I think it will be more predictable way. What do you think?

@aartikov
Copy link
Contributor Author

Hi. I plan to use VisualReview for visual regression analysis. This tool matches screenshots by names and calculates differences. So I need to send a bunch of screenshots with determinated names after test runs.
May be, separate folders is a better choice. But still there should be a reliable way to grab required folder.

@matzuk
Copy link
Member

matzuk commented Jan 5, 2020

Hi @aartikov!
I suggest completing this PR =)
There is a concern here. You resolve local task breaking some logic (saving of screenshots of all tests running per suite).
Do you want to expand your solution and implement the logic where screenshots will be saved in different folders after each suite but screenshots' names will be without timestamps?
You can take some minds and code from DocLoc solution.

@aartikov
Copy link
Contributor Author

aartikov commented Jan 5, 2020

@matzuk no problem. Yes, I can try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants