ISSUE-567: Added more logs #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitae57
requested review from
matzuk,
AzamatCherchesov,
eakurnikov and
RuslanMingaliev
as code owners
Nikitae57
force-pushed
the
ISSUE-567-More-logs-for-dialogs-safety
branch
from
55e156e
to
a244791
Compare
matzuk
reviewed
Sep 5, 2023
| @@ -114,6 +115,7 @@ class SystemDialogSafetyProviderImpl( | |||
|
|
|||
| if (systemDialogsSafetyParams.shouldIgnoreKeyboard) { | |||
| val isKeyboardVisible = isVisible(By.pkg(Pattern.compile("\\S*google.android.inputmethod\\S*")).clazz(FrameLayout::class.java)) | |||
| logger.i("Found keyboard") | |||
There was a problem hiding this comment.
Is this comment still valid here? If yes, please add more details because the log looks like typical debug stuff.
There was a problem hiding this comment.
Yeah, it could go into the void. Removed it with the last commit. I'll squash on merge
matzuk
approved these changes
Sep 5, 2023
eakurnikov
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #567