Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

Fixes #16297: Don't require base for HTML5 mode #125

Merged
merged 1 commit into from Aug 25, 2016

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 25, 2016

This base requirement leads to test failures and errors in plugins
and modules inheriting.

@ehelms
Copy link
Member Author

ehelms commented Aug 25, 2016

Ignore travis for now - thats from another PR and some testing I am doing.

@waldenraines
Copy link

I'm actually right in the middle of fixing this myself but my changes are more extensive. I can open a PR soon.

@waldenraines
Copy link

ACK and I'll open my changes on top of this PR once merged since you have an exact subset of my changes.

@waldenraines
Copy link

Actually, there is one thing I just noticed. Have you tested what will happen with older versions of IE that required application_ie.html.erb?

I'm fine handling that as a separate PR though since this is currently breaking the build.

@ehelms
Copy link
Member Author

ehelms commented Aug 25, 2016

@waldenraines hrmm, I guess I thought this requireBase was a next concept with 1.5 and by having it false things should keep working as is? I can't say I tested it though on IE.

This base requirement leads to test failures and errors in plugins
and modules inheriting.
@waldenraines
Copy link

@waldenraines hrmm, I guess I thought this requireBase was a next concept with 1.5 and by having it false things should keep working as is? I can't say I tested it though on IE.

Just removing it from application_ie.html.erb should be sufficient actually.

@waldenraines
Copy link

ACK

@ehelms ehelms merged commit 66b0839 into Katello:master Aug 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants