Fixes #5802 HC update/create using system uuids #178
Conversation
| @@ -66,6 +75,7 @@ class CopyCommand < HammerCLIKatello::CreateCommand | |||
| end | |||
|
|
|||
| class UpdateCommand < HammerCLIKatello::UpdateCommand | |||
There was a problem hiding this comment.
does this class need build_options :without => [:system_uuids] too?
There was a problem hiding this comment.
@komidore64
it's nice to have, otherwise both options
--system-uuids
--system-ids
would show up in the help dialog making it confusing to the user. https://github.com/dustint-rh/katello/blob/0867b36b1e01fe6bdf2470a17038ec6edb2bcbab/app/controllers/katello/api/v2/host_collections_controller.rb#L64
There was a problem hiding this comment.
yeah, i'm asking if this class needs it as well, because this PR isn't adding build_options :without => [:system_uuids] for the UpdateCommand. you're only adding it for the CreateCommand.
There was a problem hiding this comment.
@komidore64 ah yeah, you're right. I'm going to update.
Host Collections update/create take uuids instead of ids to follow other commands in Host Collections. Also updates Host Collections content-host command to display uuids as ids.
|
ack pending travis |
…ys_uuid Fixes #5802 HC update/create using system uuids
Host Collections update/create take uuids instead of ids to follow
other commands in Host Collections. Also updates Host Collections
content-host command to display uuids as ids.
depends on Katello/katello#4175