Fixes #6055 - HC add/remove-content-host take uuid #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +91,25 @@ class DeleteCommand < HammerCLIKatello::DeleteCommand | |||
| build_options | |||
| end | |||
|
|
|||
| HammerCLIKatello::AssociatingCommands::ContentHost.extend_command(self) | |||
| class AddCoSingleResourceCommandntentHostCommand < HammerCLIKatello::SingleResourceCommand | |||
There was a problem hiding this comment.
the class name looks a bit off... :) AddCoSingleResourceCommandntentHostCommand ?
|
ACK pending comment |
the host-collection command's --system-id option was accepting database ids instead of uuids. This uses the add_host_collections/remove_host_collections action instead of the AssociatingCommands (which uses the update action). This is a simpler approach than trying to alter/override the behavior of an AssociatingCommand to accept uuids.
dustints
pushed a commit
that referenced
this pull request
Jun 6, 2014
Fixes #6055 - HC add/remove-content-host take uuid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the host-collection command's --system-id option was accepting database
ids instead of uuids. This uses the
add_host_collections/remove_host_collections action instead of the
AssociatingCommands (which uses the update action). This is a simpler
approach than trying to alter/override the behavior of an
AssociatingCommand to accept uuids.