Fixes #13614 - Make capsule only an alias to proxy #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstrachota
force-pushed
the
proxy_alias_13614
branch
from
3216416
to
c311a27
Compare
tstrachota
force-pushed
the
proxy_alias_13614
branch
from
c311a27
to
493163d
Compare
| @@ -24,6 +24,8 @@ def self.exception_handler_class | |||
| require 'hammer_cli_katello/id_resolver' | |||
|
|
|||
| # commands | |||
| require 'hammer_cli_katello/capsule' | |||
There was a problem hiding this comment.
Why can't this be lumped into the list of other requires just a few lines up?
tstrachota
force-pushed
the
proxy_alias_13614
branch
3 times, most recently
from
1ddff99
to
0ba5dbe
Compare
|
@komidore64 thanks, updated. |
| @@ -136,7 +108,9 @@ class SyncCommand < HammerCLIForemanTasks::AsyncCommand | |||
| autoload_subcommands | |||
| end | |||
|
|
|||
| autoload_subcommands | |||
| HammerCLIForeman::SmartProxy.subcommand("content", | |||
There was a problem hiding this comment.
One more thing. Could we use HammerCLIKatello::Capsule::Content.command_name here rather than "content"? Same reason that I asked about using #desc(), it's one place to keep track of the command name, rather than two.
|
ACK pending comment. |
tstrachota
force-pushed
the
proxy_alias_13614
branch
from
0ba5dbe
to
d99c390
Compare
|
Fixed |
|
@tstrachota mind rebasing? Also, is this intended for 3.0? We branched yesterday and this will need a BZ attached to it, if you want it cherry-picked into 3.0. |
tstrachota
force-pushed
the
proxy_alias_13614
branch
from
d99c390
to
2ba9e4e
Compare
|
@komidore64 I rebased, moved the issue to Katello and cloned it to bugzilla. |
|
@tstrachota sweet! 🐈 |
komidore64
added a commit
that referenced
this pull request
Feb 29, 2016
Fixes #13614 - Make capsule only an alias to proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.