Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21701 - fix loading of FilterRuleHelpers #529

Merged
merged 1 commit into from Nov 17, 2017

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 17, 2017

fixes:

/home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:7:in `block in <module:HammerCLIKatello>': uninitialized constant HammerCLIKatello::FilterRuleHelpers (NameError)
Did you mean?  HammerCLIKatello::FilterRule
	from /home/remote/egolov/.gem/ruby/2.4.0/gems/minitest-4.7.4/lib/minitest/spec.rb:71:in `class_eval'
	from /home/remote/egolov/.gem/ruby/2.4.0/gems/minitest-4.7.4/lib/minitest/spec.rb:71:in `describe'
	from /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:6:in `<module:HammerCLIKatello>'
	from /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:5:in `<top (required)>'
	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:15:in `require'
	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:15:in `block in <main>'
	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `select'
	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!

@akofink can you please have a look? the changes were introduced by you originally

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 9daae53 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@evgeni
Copy link
Member Author

evgeni commented Nov 17, 2017

and no, I have no idea why this does not show up on travis.

Copy link
Member

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh - I've seen this before. Maybe it's Ruby 2.4? Could you please create a redmine issue to track this change? ACK pending redmine issue.

fixes:

    /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:7:in `block in <module:HammerCLIKatello>': uninitialized constant HammerCLIKatello::FilterRuleHelpers (NameError)
    Did you mean?  HammerCLIKatello::FilterRule
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/minitest-4.7.4/lib/minitest/spec.rb:71:in `class_eval'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/minitest-4.7.4/lib/minitest/spec.rb:71:in `describe'
    	from /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:6:in `<module:HammerCLIKatello>'
    	from /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:5:in `<top (required)>'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:15:in `require'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:15:in `block in <main>'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `select'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `<main>'
    rake aborted!
@evgeni evgeni changed the title fix loading of FilterRuleHelpers Fixes #21701 - fix loading of FilterRuleHelpers Nov 17, 2017
@akofink akofink merged commit 1de50d2 into Katello:master Nov 17, 2017
zjhuntin pushed a commit to zjhuntin/hammer-cli-katello that referenced this pull request Feb 2, 2018
fixes:

    /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:7:in `block in <module:HammerCLIKatello>': uninitialized constant HammerCLIKatello::FilterRuleHelpers (NameError)
    Did you mean?  HammerCLIKatello::FilterRule
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/minitest-4.7.4/lib/minitest/spec.rb:71:in `class_eval'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/minitest-4.7.4/lib/minitest/spec.rb:71:in `describe'
    	from /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:6:in `<module:HammerCLIKatello>'
    	from /home/remote/egolov/Devel/katello/hammer-cli-katello/test/functional/filter_rule/update_test.rb:5:in `<top (required)>'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:15:in `require'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:15:in `block in <main>'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `select'
    	from /home/remote/egolov/.gem/ruby/2.4.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `<main>'
    rake aborted!

(cherry picked from commit 1de50d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants