Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27261 - export-legacy should not be described as deprecated #662

Merged
merged 1 commit into from Jul 10, 2019

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Jul 10, 2019

export-legacy method has different functionality from export and should not be described as deprecated

@theforeman-bot
Copy link

Issues: #27261

@chris1984 chris1984 self-assigned this Jul 10, 2019
@Katello Katello deleted a comment from theforeman-bot Jul 10, 2019
@Katello Katello deleted a comment from theforeman-bot Jul 10, 2019
@Katello Katello deleted a comment from theforeman-bot Jul 10, 2019
@akofink akofink requested review from ehelms and removed request for ehelms July 10, 2019 13:42
Copy link
Member

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change. @chris1984 were we planning to eventually remove the legacy export? I seem to remember some discussion around removing it so it's not confusing to users. I can see why we'd want to keep the old export around, though. For one, you don't need to be running hammer locally with Foreman for the legacy export.

@chris1984
Copy link
Member

@akofink yeah there was talk about removing it but I am not sure where that went. Since I have not seen anything new around that topic I am fine with this change too since we are still supporting both ways. Marking as approved. Thanks, @wbclark 🍻

@wbclark
Copy link
Contributor Author

wbclark commented Jul 11, 2019

@akofink @chris1984 Thank you for the quick turnaround on this one! Export-legacy does provide different functionality than the new export method, for example the new export method will fail when trying to export any CV version that contains non-RPM content, additionally the format of the exported content is different and some users have processes that are specifically dependent on that formatting. Therefore it's important to continue to support export-legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants