Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36795 - Prepare for SCA-Only #911

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

lfu
Copy link
Member

@lfu lfu commented Oct 2, 2023

hammer organization update - When disabling SCA, hammer should remind users that non-SCA is going away in Katello 4.12.
hammer simple-content-access disable - hammer should remind users that non-SCA is going away in Katello 4.12.

@theforeman-bot
Copy link

Issues: #36795

@lfu
Copy link
Member Author

lfu commented Oct 2, 2023

$ hammer organization update --id 1 --simple-content-access false
Simple Content Access will be required for all organizations in Katello 4.12.
Organization updated.
$ hammer simple-content-access disable --organization-id 1
Simple Content Access will be required for all organizations in Katello 4.12.
[......................................................................................................] [100%]

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, looks good and works as described.

@chris1984
Copy link
Member

Rubocop is not happy :(

Offenses:

lib/hammer_cli_katello/organization.rb:79:11: C: Favor unless over if for negative conditions.
          if !params['simple_content_access'] ...
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@chris1984 chris1984 self-assigned this Oct 2, 2023
@lfu
Copy link
Member Author

lfu commented Oct 3, 2023

Rubocop is not happy :(

It is right!

@chris1984
Copy link
Member

ACK, ship it

@lfu lfu merged commit 3bc7d4c into Katello:master Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants