Fixes #36964 - SCA deprecation message - next release #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfu
reviewed
Dec 7, 2023
| @@ -77,7 +77,7 @@ def request_params | |||
| params["organization"] = params.fetch('organization', {}).merge( | |||
| "_simple_content_access" => params['simple_content_access']) | |||
| unless params['simple_content_access'] | |||
| warn "Simple Content Access will be required for all organizations in Katello 4.12." | |||
| warn "Simple Content Access will be required for all organizations in the next release." | |||
lfu
reviewed
Dec 7, 2023
| @@ -47,7 +49,7 @@ class DisableCommand < HammerCLIKatello::SingleResourceCommand | |||
| build_options | |||
|
|
|||
| def execute | |||
| warn "Simple Content Access will be required for all organizations in Katello 4.12." | |||
| warn "Simple Content Access will be required for all organizations in the next release." | |||
ianballou
force-pushed
the
36946-sca-dep-next-release
branch
from
80f0f54
to
29b15fb
Compare
|
|
|
Test failure is related. |
ianballou
force-pushed
the
36946-sca-dep-next-release
branch
from
29b15fb
to
674c130
Compare
ianballou
added a commit
to ianballou/hammer-cli-katello
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 3b5cce2)
ianballou
added a commit
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 3b5cce2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the Katello 4.12 message to say "next release" so that projects using Katello don't have to worry about translating the name.
To test:
hammer simple-content-access disable --organization-id 1-> See the warning
hammer organization update --id 1 --simple-content-access false-> See the same warning
This will need to be CP'd to the 1.11.z branch.
Also fixes an issue I found:
The simple content access class was missing a
:resource.