refs #9403 - get rhsm certificate from rhsm configration #20
Conversation
| @@ -117,10 +117,11 @@ def setup_plugin(): | |||
| cfg = plugin.cfg() | |||
| rhsm_conf = Config(RHSM_CONFIG_PATH) | |||
| certificate = ConsumerIdentity.read() | |||
| cfg.messaging.cacert = rhsm_conf['rhsm']['repo_ca_cert'] % rhsm_conf['rhsm'] | |||
There was a problem hiding this comment.
Does this handle the string substitution from rhsm.conf?:
repo_ca_cert = %(ca_cert_dir)skatello-server-ca.pem
There was a problem hiding this comment.
Does the Config() object handle that for you? as i see the test below testing that.
There was a problem hiding this comment.
Unfortunately Config doesn't do it, which is why I'm doing the substitution with the rhsm_conf['rhsm'] dict.
I wonder if we can't get this hooked up to Jenkins? Not urgent, I ran the tests locally and they pass. I need to get a jenkins account one of these days...
There was a problem hiding this comment.
ohhhh i see, i was a tad confused there.
|
ACK from me |
|
and +1 to getting jenkins test runs. I'll see about setting up a job and we can point the PR processor at it i think |
|
@jlsherrill It needs a bunch of dependencies, it took a bit to figure out, but it was mostly python-gofer and pulp stuff. If those are installable with pip on Ubuntu, we could use Travis. |
|
Thanks! |
refs #9403 - get rhsm certificate from rhsm configration
Use --relaxed flag when adding URL for sources pulling from master.
No description provided.