Fixes #10670 - preffer the katello-default-ca.pem as the client ca cert #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed by candlepin-local.pem for backward compatibility and the repo_ca_cert as fallback.
|
ACK |
iNecas
added a commit
that referenced
this pull request
Jun 2, 2015
Fixes #10670 - preffer the katello-default-ca.pem as the client ca cert
| # legacy installer was putting this file. If none of them is present, there is still | ||
| # a chance the rhsm_conf['rhsm']['repo_ca_cert'] is serving as the CA for issuing | ||
| # the client certs | ||
| ca_candidates = [ca_cert_dir + 'katello-default-ca.pem', ca_cert_dir + 'candlepin-local.pem', rhsm_conf['rhsm']['repo_ca_cert'] % rhsm_conf['rhsm']] |
There was a problem hiding this comment.
Using os.path.join() instead of (+) would be safer. The value of ca_cert_dir may not end with a '/'.
There was a problem hiding this comment.
I've opened new PR for this #24
zjhuntin
pushed a commit
to zjhuntin/katello-agent
that referenced
this pull request
Jan 23, 2017
fixes #11261 - wait a little after starting httpd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed by candlepin-local.pem for backward compatibility and the
repo_ca_cert as fallback.
Requires theforeman/puppet-certs#62 to work properly.