This repository has been archived by the owner on Oct 9, 2018. It is now read-only.
1012572: Check the upload type against the repo's content type #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are we checking the content type in the CLI and not the API? 1. The content type is not being passed to the API. The content type is used to parse the upload's metadata which happens in the CLI and not API (we copied pulp's python code over to do the metadata parsing). 2. It's better to do it before we upload the package than at the very end. If we were to pass the content type to the API, we probably wouldn't do it until import_into_repo which is the last call (after the package or module gets uploaded). This would mean the user would have to sit through actually uploading the package before knowing it wasn't valid.
|
ACK |
daviddavis
pushed a commit
that referenced
this pull request
Sep 30, 2013
1012572: Check the upload type against the repo's content type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we checking the content type in the CLI and not the API?