Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle setups without Puppet #364

Merged
merged 2 commits into from Apr 19, 2022
Merged

better handle setups without Puppet #364

merged 2 commits into from Apr 19, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Apr 14, 2022

  • check for "Puppet" feature when moving between proxies
  • don't setup Puppet agent when no Puppet environment could be found

- check for "Puppet" feature when moving between proxies
- don't setup Puppet agent when no Puppet environment could be found
Copy link
Contributor

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it reads ok.

@evgeni
Copy link
Member Author

evgeni commented Apr 14, 2022

FWIW, this is fixing https://bugzilla.redhat.com/show_bug.cgi?id=2075434

pylint 2.13+ has a bug with disable=R and ignore-imports=y, which we
use.

See pylint-dev/pylint#6301 for details
@evgeni evgeni merged commit 971815b into master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants