This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Fixes #14098 - Removed steps to register #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why would it be registered already? You could argue registration is no longer required with the host unification changes @jlsherrill correct if I am misspeaking. |
|
@ehelms I based the pr off of this downstream BZ https://bugzilla.redhat.com/show_bug.cgi?id=1194162 |
|
I like his suggestion in the bug, mentioning to the user the need to register if they have not already registered to the Satellite or want to manage the Capsule's content and errata. Perhaps just the former to impress best practices to the user. |
|
@ehelms Ack, I will fix my commit and update the wording on the steps I took out. |
Removed steps to register capsule since it would be registered already. Fixes #14098 - Removed steps to register Advised user to make sure smartproxy is registered correctly to Katello Instance
|
change looks good to me, ACK |
|
@ehelms does this look good for a merge |
|
Thanks @chris1984 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed steps to register capsule since it would be registered already.