Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

fixes #15158 - support multiple paths for katello-certs-check #341

Merged
merged 1 commit into from Jun 6, 2016

Conversation

stbenjam
Copy link
Contributor

katello-certs-check is either in the katello-installer directory
(git repo) or in foreman-installer-katello (rpm install). This supports
both cases.

For 3.1, would it just make sense to combine these into 2 packages? I wasn't sure if there's a technical reason for why we keep foreman-installer-katello and katello-installer-base as 2 separate packages.

@ehelms
Copy link
Member

ehelms commented May 26, 2016

I wonder if we should just install the script via RPM so its available system wide and avoid path wars?

@stbenjam
Copy link
Contributor Author

I wonder if we should just install the script via RPM so its available system wide and avoid path wars?

Yea, it is in $PATH so we could just do that now, except for development installs. Is it ever needed there?

@ehelms
Copy link
Member

ehelms commented May 26, 2016

For testing and using custom certs I could see it being useful.
On May 26, 2016 7:52 AM, "Stephen Benjamin" notifications@github.com
wrote:

I wonder if we should just install the script via RPM so its available
system wide and avoid path wars?

Yea, it is in $PATH so we could just do that now, except for development
installs. Is it ever needed there?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#341 (comment)

@stbenjam stbenjam force-pushed the 15158 branch 2 times, most recently from ea5f592 to 314ad80 Compare June 1, 2016 15:07
@stbenjam
Copy link
Contributor Author

stbenjam commented Jun 1, 2016

Ah, well, it is in the package even on dev installs, and it's in $PATH. So, updated to use which.

@ehelms
Copy link
Member

ehelms commented Jun 6, 2016

ACK

@stbenjam stbenjam merged commit 83f1166 into Katello:master Jun 6, 2016
@stbenjam stbenjam deleted the 15158 branch June 6, 2016 15:45
ehelms pushed a commit to ehelms/katello-installer that referenced this pull request Jun 17, 2016
zjhuntin pushed a commit to zjhuntin/katello-installer that referenced this pull request Oct 30, 2018
fixes #12930 - send content view version id correctly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants