Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Fixes #4770: Adding reset option to installer script. #37

Merged
merged 1 commit into from Apr 16, 2014

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Mar 28, 2014

No description provided.

@elyezer
Copy link

elyezer commented Mar 28, 2014

This will help QE to get a clean system without having to install the entire system, thanks.

@ehelms
Copy link
Member Author

ehelms commented Apr 3, 2014

Scratch build if interested - http://koji.katello.org/koji/taskinfo?taskID=97139

@elyezer
Copy link

elyezer commented Apr 5, 2014

Cool, will test it and give some feedback if I find something. Thank you

app_option(
'--reset',
:flag,
"Drop Katello database first? You will lose all data! Unfortunately we\n" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Drop Katello database first?"

Yes? No? I'm confused.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated to reduce confusion.

@jlsherrill
Copy link
Member

I do notice that /var/lib/pulp/content is still populated with all the binary content along with /etc/puppet/environments/.

pulp content is probably less of concern, but /etc/puppet/environments will cause entities to pop up in foreman, so I could see a stronger argument for removing that.

@jlsherrill
Copy link
Member

Other than the above comment (which could be addressed separately), everything looks good to me, and ACK.

@ehelms
Copy link
Member Author

ehelms commented Apr 14, 2014

@jlsherrill we could add an additional flag to indicate full data clearance if you feel that should be included as part of this PR or two separate flags - one for clearing puppet and one for clearing pulp content (or an issue to address each).

@jlsherrill
Copy link
Member

@ehelms yeah, sounds good to me, i'll open a couple issues

@jlsherrill
Copy link
Member

ACK

ehelms added a commit that referenced this pull request Apr 16, 2014
Fixes #4770: Adding reset option to installer script.
@ehelms ehelms merged commit 88f95d5 into Katello:master Apr 16, 2014
@ehelms ehelms deleted the fixes-4770 branch April 16, 2014 19:58
bbuckingham pushed a commit to bbuckingham/katello-installer that referenced this pull request Oct 29, 2015
Fixes #7802 - allow user to be passed into qpid module
zjhuntin pushed a commit to zjhuntin/katello-installer that referenced this pull request Oct 30, 2018
Content views: support for view repositories
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants