This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Fixes #16354 - Add rubocop #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
temp/20160826171555
branch
2 times, most recently
from
e63c4be
to
592b39e
Compare
| @@ -72,7 +72,7 @@ def fix_katello_settings_file | |||
|
|
|||
| return true unless settings.key?(:common) | |||
|
|
|||
| settings = {:katello => settings[:common]} | |||
| settings = { :katello => settings[:common] } | |||
There was a problem hiding this comment.
Is this normal? Seems strange to have a leading space.
There was a problem hiding this comment.
That is odd but it seems that's what rubocop does by default. I'm going to copy over the setting from katello: https://git.io/v6x9s
|
Nice! I'd be thinking about this but of course you are the king of rubocop. |
daviddavis
force-pushed
the
temp/20160826171555
branch
from
592b39e
to
9f8e07e
Compare
|
This should be good to go 👑 |
daviddavis
force-pushed
the
temp/20160826171555
branch
3 times, most recently
from
2b5a38d
to
a600eb9
Compare
|
ACK - thanks @daviddavis |
zjhuntin
pushed a commit
to zjhuntin/katello-installer
that referenced
this pull request
Oct 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.