This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Fixes #17191 - don't continue with upgrade on db migrate error #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
|
@iNecas LGTM, please just make @theforeman-bot happy |
Before this patch, we were ignoring the results of db:migrate rake task in pre-upgrade hook. While sometimes it helped us with issues, when the second run of db:migrate inside the installer would finish successfully (just because of some combination plugins or jumping though multiple versions). We should however rather be aware of the issues and fixing them, rather than ignoring it, with potential consequences later.
stbenjam
force-pushed
the
dont-ignore-db-migrate-errors
branch
from
5428ef8
to
6aeb1d1
Compare
|
Thanks @iNecas! Merging, I made Mr. @theforeman-bot happy for you |
ehelms
pushed a commit
to ehelms/katello-installer
that referenced
this pull request
Mar 9, 2017
…lo#471) Before this patch, we were ignoring the results of db:migrate rake task in pre-upgrade hook. While sometimes it helped us with issues, when the second run of db:migrate inside the installer would finish successfully (just because of some combination plugins or jumping though multiple versions). We should however rather be aware of the issues and fixing them, rather than ignoring it, with potential consequences later. (cherry picked from commit 24ef11b)
zjhuntin
pushed a commit
to zjhuntin/katello-installer
that referenced
this pull request
Oct 30, 2018
Provide proper error message to indicate required organization options for content-view name in hostgroup create/update. These messages are especially important for these commands because the organization options are `--query-organization[-id|-label]` rather than just `--organization[-id|-label]`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, we were ignoring the results of db:migrate rake task in
pre-upgrade hook. While sometimes it helped us with issues, when the second run
of db:migrate inside the installer would finish successfully (just because of
some combination plugins or jumping though multiple versions). We should
however rather be aware of the issues and fixing them, rather than ignoring it,
with potential consequences later.