Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Fixes #23242 - Add cli plugins to Katello scenario #612

Merged
merged 1 commit into from Apr 19, 2018
Merged

Fixes #23242 - Add cli plugins to Katello scenario #612

merged 1 commit into from Apr 19, 2018

Conversation

chris1984
Copy link
Member

No description provided.

@theforeman-bot
Copy link

Issues: #23242

Copy link
Contributor

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but it might be nice if we'd just dump all of them in there, e.g. discovery, rex, etc:

https://github.com/theforeman/puppet-foreman/tree/master/manifests/cli

Although foreman only has the two we have now, so foreman-installer would need it too.

And one other thought: since katello pulls in openscap plugin, should this be true by default?

@chris1984
Copy link
Member Author

chris1984 commented Apr 19, 2018

Sounds good, I will add them and resubmit the changes. I agree with setting it to true.

@chris1984
Copy link
Member Author

@stbenjam updated.

Copy link
Contributor

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

(For future visitors: they're false since the foreman plugins are false in Katello, I was mistaken about the true thing.)

@chris1984 chris1984 changed the title Fixes #23242 - Add scap to Katello scenario Fixes #23242 - Add cli plugins to Katello scenario Apr 19, 2018
@chris1984 chris1984 merged commit 0d7f961 into Katello:master Apr 19, 2018
@chris1984 chris1984 deleted the add-scap branch April 19, 2018 14:09
@ekohl
Copy link
Member

ekohl commented Apr 22, 2018

@stbenjam I indeed was starting to add them all. theforeman/puppet-foreman@b04778a should make it easy to add all plugins. I was starting to look into a way to automatically install matching CLI plugins for the normal plugins but haven't found one (though I didn't spend much time on it).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants