Fixes #14125 - Updating katello-remove cleanup #189
Conversation
| @@ -6,7 +6,7 @@ echo "Important packages such as the following will be removed:" | |||
| echo "" | |||
| echo " * httpd (apache)" | |||
| echo " * mongodb" | |||
| echo " * tomcat6" | |||
| echo " * tomcat" | |||
There was a problem hiding this comment.
technically it is still tomcat6 on rhel 6, but I think this update is more correct 🐈
|
@chris1984 which part removes /etc/gutterball? the |
| @@ -103,13 +103,12 @@ RPMS=( | |||
| `rpm -qa | grep ^python-isodate` | |||
| `rpm -qa | grep gutterball` | |||
There was a problem hiding this comment.
@beav gutterball is already being removed in katello-remove I have modified katello-backup which is coming in a new PR
|
@beav still looking at a few things, please hold of on a merge till I give the thumbs up on my side. |
| /var/lib/hiera | ||
| /usr/share/qpid | ||
| /usr/share/qpid-tools | ||
| /usr/share/katello-installer |
There was a problem hiding this comment.
I think this is /usr/share/katello-installer-base, there will also be /usr/share/foreman-installer. There is also now /etc/foreman-installer for Katello 3.0 @mbacovsky any I am missing?
There was a problem hiding this comment.
+1 to /etc/foreman-installer as well as:
/var/log/foreman-installer/
/var/www/html/pub/katello-server-ca.crt
/usr/share/foreman-installer-katello
/etc/sudoers.d/foreman-proxy
/etc/hammer/
/usr/share/foreman-proxy
/var/cache/pulp
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@chris1984 looks like there are still some comments to address for this PR |
|
@ehelms thanks yep still working on it, that was Brad helping me trying to get past a troublesome rebase, should have this addressed this week. |
Updating katello-remove to clean up orhpaned directories Fixes #14125 - Updating katello-remove cleanup
|
ACK - removed and re-installed without issue |
|
Thanks @chris1984 ! |
Updating katello-remove to clean up orhpaned directories Fixes #14125 - Updating katello-remove cleanup (cherry picked from commit bf93ccb)
Updating katello-remove to clean up orhpaned directories