Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Fixes #15146 - service-wait now correctly handles tomcat #229

Merged
merged 1 commit into from May 26, 2016

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented May 20, 2016

No description provided.

@@ -57,7 +57,7 @@ before_start() {
# after start or restart
after_start() {
case "$SERVICE" in
tomcat6|tomcat7)
tomcat|tomcat6|tomcat7)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tomcat7 can actually be removed, not sure that's the name of any service

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Redmine issue to pull this in would be nice as well.
On May 20, 2016 6:15 PM, "Stephen Benjamin" notifications@github.com
wrote:

In katello/service-wait
#229 (comment)
:

@@ -57,7 +57,7 @@ before_start() {

after start or restart

after_start() {
case "$SERVICE" in

  • tomcat6|tomcat7)
  • tomcat|tomcat6|tomcat7)

I think tomcat7 can actually be removed, not sure that's the name of any
service


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/Katello/katello-packaging/pull/229/files/76bb064d9dcef0b9e488b184b7ca4b796a563c41#r64114823

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 'before_stop' also be updated?

@ehelms ehelms changed the title service-wait now correctly handles tomcat Fixes #15146 - service-wait now correctly handles tomcat May 24, 2016
@ehelms
Copy link
Member

ehelms commented May 26, 2016

Thanks @parthaa !

@ehelms ehelms merged commit b56fc78 into Katello:master May 26, 2016
ehelms pushed a commit that referenced this pull request May 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants