Skip to content
This repository has been archived by the owner on Oct 9, 2018. It is now read-only.

Allow linking to sections in pages by adding IDs to headers. #16

Merged
merged 1 commit into from
Jul 10, 2014
Merged

Allow linking to sections in pages by adding IDs to headers. #16

merged 1 commit into from
Jul 10, 2014

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jul 10, 2014

No description provided.

@daviddavis
Copy link
Contributor

Technically you can do this with redcarpet's with_toc_data option. If you want to use kramdown tho, then ACK.

@ehelms
Copy link
Member Author

ehelms commented Jul 10, 2014

@daviddavis redcarpet produces IDs that are toc_1, toc_2 whereas kramdown converts # Code Conventions to code-conventions which seemed more readable and robust to moving sections around to me. Thoughts?

@daviddavis
Copy link
Contributor

Ah, kramdown sounds better. ACK.

ehelms added a commit that referenced this pull request Jul 10, 2014
@ehelms
Merge pull request #16 from ehelms/link-to-sections
a52de75 
Allow linking to sections in pages by adding IDs to headers.
@ehelms ehelms merged commit a52de75 into Katello:master Jul 10, 2014
@ehelms ehelms deleted the link-to-sections branch July 10, 2014 19:25
@daviddavis daviddavis mentioned this pull request Jul 11, 2014
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehelms @daviddavis