Fixes #37191 - upload profile via REX #10900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
reviewed
Feb 21, 2024
|
Done @jeremylenz |
|
@sbernhard Now that this improvement is being added, I think it's appropriate to also update the frontend changes introduced in https://github.com/Katello/katello/pull/10501/files so that we use this new feature instead of the "run command" feature. Are you open to including those changes here? If not, we can also open a separate issue for it. |
|
@jeremylenz I think its better to have another PR to update the frontend. Would be good if someone else can work on this. Or I will come back to in about 2-3 weeks (sorry for that - priorities....) |
jeremylenz
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
@sbernhard that's fair. Opened https://projects.theforeman.org/issues/37225.
Tested and works as advertised. ACK 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?