refs #7779 - Updating to add support for pulp crane

[bbuckingham]

This is the initial PR to add the puppet-crane module.

This module does a simple config of the Pulp Crane application.

[ekohl]

This means they're hardcoded. I'd at least set it to $crane::cert, but also strongly consider adding them as class parameters:

class crane::apache (
  $cert = $crane::cert,
  $key  = $crane::key,
  $ca   = $crane::ca,
) {

The benefit is that you can easily test this class without including the crane class and still pass in various parameters. That helps with performance. It can also help you when you use templates because they're already in scope and there's no need for the clunky scope.lookup function.

[ehelms]

Ideally this would include a use_ssl param and setup a vhost for SSL only if that was specified. However, I'd be OK with sticking to SSL only for now but would encourage removing the direct dependency on Certs and just allow passing in the cert files. This will make this module simpler and more re-usable.

[ekohl]

@ehelms that sounds like a very good idea and could easily be done by defaulting to undef instead of certs::*.

[ekohl]

s/andaa/and/

[ehelms]

Should probably add EL7 here as well.

[ekohl]

An admin should enable travis integration so the tests are actually executed btw.

[ehelms]

I think you can get rid of this dependency now that you've reworked the certs and expecting them to be handed to Crane.

[ehelms]

Also, one thing you could potential do is use the validators (https://github.com/puppetlabs/puppetlabs-stdlib -- search for validate) to ensure the certs are passed in

[ehelms]

Sorry I didn't catch this the first time! Conventionally these should be pointing at the params

@key = $crane::params::key,
@cert = $crane::params::cert,
@ca_cert = $crane::params::ca_cert,

[ehelms]

APT

[ekohl]

👍 looks good to me.

[bbuckingham]

@ekohl, @ehelms, Thanks for the review & feedback!